[RyanQiu1] iP #75

RyanQiu1 · 2023-01-21T15:00:01Z

Duke Bot

Bot that is here to help you and your tasks out!

Duke bot is:

Texted Based
Easy to use
~~Slow~~ Fast!

Here are the steps involved!

Download the Jar file from here
Click It!
Add your tasks!
Use it daily! 😀

Most importantly Free Software

Features in this software

Add todo tasks, events and deadlines
Delete tasks whenever you want
Saves your tasks and updates automatically!

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…he user, first is to handle the unknown command error and next is to handle the empty field error

…changes. Load the data from the hard disk when Duke starts up.

…tests to the classes

# Conflicts: # src/main/java/duke/parser/Parser.java # src/main/java/duke/task/Task.java # src/main/java/duke/task/TaskList.java

# Conflicts: # src/main/java/duke/parser/Parser.java

joyngjr

Looks good!
Most of your code follows the coding standards, just that some minor tweaks are needed for your boolean methods, switch-case indentation and if-else blocks.

joyngjr · 2023-01-31T00:50:56Z

src/main/java/duke/command/DeleteCommand.java

+        this.listNum = taskNumberMark;
+    }
+
+    public boolean execute(TaskList tasks, Ui ui, StorageList storage) {


Perhaps this boolean method can be made to sound like a boolean (eg. canExecute)?

joyngjr · 2023-01-31T00:53:46Z

src/main/java/duke/command/EventCommand.java

+        this.to = checkerTo[1];
+    }
+
+    public boolean execute(TaskList tasks, Ui ui, StorageList storage) {


I noticed your naming convention for boolean methods in several other places too. Might be good to make them sound more like a boolean.

joyngjr · 2023-01-31T00:55:17Z

src/main/java/duke/parser/Parser.java

+        String[] input2 = input.split(" ");
+        Type t = Type.valueOf(input2[0].toLowerCase());
+        switch (t) {
+            case todo:


Should the indentation of your switch-case statement be the same?

joyngjr · 2023-01-31T00:56:35Z

src/main/java/duke/storage/StorageList.java

+    public void updateStorage() {
+        try {
+            File dir = new File("data");
+            if (!dir.exists()) dir.mkdirs();


Shouldn't your conditionals be placed on a different line, and be wrapped in curly braces?

joyngjr · 2023-01-31T00:58:14Z

src/main/java/duke/task/Task.java

+
+    public String toString() {
+        if (typeofTask.equals(""))
+            return "[" + this.getStatusIcon() + "]" + " " + this.description;


Same issue as with StorageList.java, shouldn't the if-block be wrapped in curly braces?

Yes u are right, i have rectified it.

joyngjr · 2023-01-31T00:59:24Z

src/main/java/duke/task/TaskList.java

+    public ArrayList<Task> find(String message) {
+        ArrayList<Task> arrStr = new ArrayList<>();
+        for (Task t: list) {
+            if (t.toString().contains(message)) {


Good job adding curly braces here! 👍

# Conflicts: # build.gradle # src/main/java/duke/Duke.java # src/main/java/duke/command/ByeCommand.java # src/main/java/duke/command/DeadlineCommand.java # src/main/java/duke/command/DeleteCommand.java # src/main/java/duke/command/EventCommand.java # src/main/java/duke/command/FindCommand.java # src/main/java/duke/command/ListCommand.java # src/main/java/duke/command/MarkCommand.java # src/main/java/duke/command/TodoCommand.java # src/main/java/duke/command/UnmarkCommand.java # src/main/java/duke/task/TaskList.java

There is a addition of a title and appears more aesthetically pleasing. Adding the images and improving the UI, with setTitle() and getIcons().add(). To enable the user to see the application they are accessing and the icon of the software.

Added assertions and fixed the removed unused UI

Improve code quality by changing names, changing oop structure.

…-CodeQuality # Conflicts: # data/duke.txt # src/main/java/duke/command/DeadlineCommand.java # src/main/java/duke/command/FindCommand.java # src/main/java/duke/command/MarkCommand.java # src/main/java/duke/command/TodoCommand.java # src/main/java/duke/command/UnmarkCommand.java

wxxedu

Overall, I think your code is really structured and follows the coding standard very well.

wxxedu · 2023-02-05T07:12:40Z

src/main/java/duke/command/DeadlineCommand.java

+    private String timing;
+
+    public DeadlineCommand(String fullCommand) {
+        String[] checker = fullCommand.split("/by ");


May I know why this is called checker???

wxxedu · 2023-02-05T07:13:32Z

src/main/java/duke/command/DeleteCommand.java

+ * Delete Command to remove the tasks users do not want, according to its number on the list.
+ */
+public class DeleteCommand extends Command {
+    private int listNum;


Can I clarify what listNum is used for? Would it be better to call it index or something?

wxxedu · 2023-02-05T07:14:12Z

src/main/java/duke/command/EventCommand.java

+    public EventCommand(String input) {
+        String[] checkerSlash = input.split("/");
+        String[] checkerEvent = checkerSlash[0].split("event ");
+        String[] checkerFrom = checkerSlash[1].split("from ");


Would it be better if we rename it to fromChecker or something related?

damithc and others added 23 commits July 31, 2022 17:20

Add Gradle support

556af3f

Greet, Echo, Exit functions added

9bff835

Add, List and new StorageList class to the functions

e564904

Add the ability to mark tasks as done and undone

0134bf7

Add support for tracking three types of tasks, todos, deadline, events

e2d6783

Automated Text UI Testing function added

041645c

Making Duke to deal with errors such as incorrect inputs entered by t…

ba5309b

…he user, first is to handle the unknown command error and next is to handle the empty field error

Add support for deleting tasks from the list.

21cb205

Added enums to my classes

97502ba

Save the tasks in the hard disk automatically whenever the task list …

40ff959

…changes. Load the data from the hard disk when Duke starts up.

Teach Duke how to understand dates and times, added these functions

40a22ff

Made code more OOP styled and according to the standards

4c46ed2

Organized the classes into suitable java packages, Command, Task, etc

cfbd82a

Update File allocation of exception

df27cfc

Merge remote-tracking branch 'origin/add-gradle-support'

dc0bcae

Use Gradle to automate some of the build tasks of the project, add 2 …

88a119c

…tests to the classes

Added JavaDoc comments to the code.

2b71c98

Tweaked the code to comply with a given coding standard

0502523

Allow users to find a task by searching for a keyword from the chatbot

da78e00

Merge tag 'A-CodingStandard'

fe725eb

# Conflicts: # src/main/java/duke/parser/Parser.java # src/main/java/duke/task/Task.java # src/main/java/duke/task/TaskList.java

Merge branch 'branch-Level-9'

6ff7104

# Conflicts: # src/main/java/duke/parser/Parser.java

Update Bye Command

c6517f2

Resolve all the conflict errors

175bf2f

RyanQiu1 changed the title ~~RyanQiu1~~ [RyanQiu1] iP Jan 28, 2023

Added Checkstyle to detect code violations

41c06ed

joyngjr reviewed Jan 31, 2023

View reviewed changes

RyanQiu1 added 4 commits February 1, 2023 10:49

Used JavaFX to make a GUI

831294a

Fixed build gradle file error

273df87

Fixed some code formatting error.

c74612a

RyanQiu1 and others added 9 commits February 3, 2023 09:56

Default duke text and stage default image.

65e8efb

There is a addition of a title and appears more aesthetically pleasing. Adding the images and improving the UI, with setTitle() and getIcons().add(). To enable the user to see the application they are accessing and the icon of the software.

Added assertions and fixed the removed unused UI

429c074

Improve code quality by changing names, changing oop structure.

f2e53ce

Merge pull request #1 from RyanQiu1/branch-A-Assertions

0bc7c6a

Added assertions and fixed the removed unused UI

Merge branch 'master' into branch-A-CodeQuality

7afc112

Merge pull request #2 from RyanQiu1/branch-A-CodeQuality

ce7967c

Improve code quality by changing names, changing oop structure.

Used GitHub Actions to set up Continuous Integration (CI).

c141f7e

Fixed Checkstyle error.

b62ba55

wxxedu reviewed Feb 5, 2023

View reviewed changes

RyanQiu1 added 17 commits February 5, 2023 15:22

Adjusted gradle.yml file to fit CI constraints.

80c978c

Implemented the tagging of tasks with a few checkstyle fixes.

de5f1bb

Fixed the Assertion test.

04bab53

Update for the name ok chatbot and the fonts.

c400a93

Updated the user guide.

0b69747

Fixed Checkstyle issues.

6d1f6fc

Update Ui screenshots and readme to follow the required format.

53c9f00

Update readme file to fix hyperlink errors.

a9469c8

Update readme for relative hyperlink.

cad2915

Update readme to fixed relative hyperlink issue.

2fc60b2

Update Junit Tests to include more test cases.

b64a0b0

Fix checkstyle issues.

b74051b

Fix readme table rendering.

69a3612

Fix readme table error.

3ba5f42

Fix readme file.

945e58a

Fix readme file.

4ae1df8

Edit starting message of bot.

13876d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RyanQiu1] iP #75

[RyanQiu1] iP #75

RyanQiu1 commented Jan 21, 2023 •

edited

joyngjr left a comment

joyngjr Jan 31, 2023

joyngjr Jan 31, 2023

joyngjr Jan 31, 2023

joyngjr Jan 31, 2023

joyngjr Jan 31, 2023

RyanQiu1 Feb 3, 2023 •

edited

joyngjr Jan 31, 2023

wxxedu left a comment

wxxedu Feb 5, 2023

wxxedu Feb 5, 2023

wxxedu Feb 5, 2023

[RyanQiu1] iP #75

Are you sure you want to change the base?

[RyanQiu1] iP #75

Conversation

RyanQiu1 commented Jan 21, 2023 • edited

Duke Bot

joyngjr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RyanQiu1 Feb 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wxxedu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RyanQiu1 commented Jan 21, 2023 •

edited

RyanQiu1 Feb 3, 2023 •

edited