[linustws] iP #95
Open
[linustws] iP #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level-7
anchengyang
reviewed
Jan 31, 2023
| import duke.task.Deadline; | ||
| import duke.task.Event; | ||
| import duke.task.Todo; | ||
|
|
There was a problem hiding this comment.
Maybe this empty line could be removed
| public static Command parse(String fullCommand) throws DukeException { | ||
| String[] parts = fullCommand.split(" ", 2); | ||
| int indexInput; | ||
| switch(parts[0].trim()) { |
There was a problem hiding this comment.
switch cases statements do not need an indent as per the coding convention
anchengyang
reviewed
Jan 31, 2023
src/main/java/duke/task/Event.java
Outdated
| LocalDate endDate = null; | ||
| LocalDateTime endDateTime = null; | ||
| DateTimeFormatter[] formatters = { | ||
| DateTimeFormatter.ofPattern("ddMMyyyy HHmm"), |
There was a problem hiding this comment.
Good job on including so many datetime formats for Event class even when it is not one of the required increments 👍
| @@ -0,0 +1,142 @@ | |||
| package duke.ui; | |||
src/test/java/duke/DukeTest.java
Outdated
| @@ -0,0 +1,120 @@ | |||
| package duke; | |||
There was a problem hiding this comment.
very comprehensive test cases that tests for almost all features
src/test/java/duke/ui/UiTest.java
Outdated
| package duke.ui; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
There was a problem hiding this comment.
Maybe all these empty lines between import statements can be removed?
Create _config.yml and add theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke (BorzAI Edition)
Let BorzAI unleash the full potential of your mind by memorising things you need to do so you don't have to. It's,
EASYSUPER EASY to useAll you have to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: