[Cocoanautz] ip #219

cocoanautz · 2024-01-30T04:14:24Z

Drew, The chat-bot of all time.

"He who does not remember his tasks, will not do them." - Sun Tzu

Do you want to be:

Productive
Up to date
Great

If you answered YES to all the above, then Drew is The buddy for you!

All you need to do to achieve greatness is:

Download the code from here.
Start up the chat-bot.
Key in your tasks.

Features include:

Cool pal to talk to 😎
No nonsense. Only do what you need to do. 💯

Look at how cool this response in the executeCommand method is:

int firstBackslashIndex = input.indexOf("/by");
if (firstBackslashIndex == -1) {
    throw new IllegalArgumentException("Incorrect input. Ensure that date begins with /by");
}

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

# Conflicts: # src/main/java/Duke.java

Date datatype in Deadline and Event objects have been updated from String to LocalDate to support more date related functions.

Moved the save and load functions out of the main method to decouple storage functionality from main logic. Storage is now accessed with filePath and Arraylist.

Refactored UI, Storage, Parsing and List functionality into respective packages and classes.

maze508

LGTM. There are only some minor code quality issues that you can easily fix and missing javadocs for some of your classes and methods. Well Done!

maze508 · 2024-02-05T04:59:23Z

src/main/java/drew/tasktypes/Task.java

+        this.isDone = false;
+    }
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


Do not repeat in comments information that is already obvious from the code

maze508 · 2024-02-05T05:04:06Z

src/main/java/Drew.java

+                throw new InsufficientArgumentsException("'Mark index' cannot be empty");
+            }
+            break;
+        //valid integer will be checked later


Comments should target other programmers reading the code and not only make sense to the person who wrote it

maze508 · 2024-02-05T05:11:44Z

src/main/java/Drew.java

+     * @param input String containing full user input.
+     * @return Command specified by user input.
+     */
+    public static Command checkCommandIdentity(String input) throws UnknownCommandException,


Avoid complicated expressions and definitions. Your method checkCommandIdentity gets the userCommand by checking for string equivalence, then uses the userCommand to perform a conditional switch case check. This can be combined into 1 and reduce redundant checkings and simplify your method to make it more easily readble

maze508 · 2024-02-05T05:13:19Z

src/main/java/Drew.java

+        }
+    }
+
+    public static String executeCommand(ArrayList<Task> ls, String input) {


Avoid Long Methods, you can consider calling another method to process your different userCommands

…2324S2/ip

Unit tests currently cover Parser.checkCommandIdentity() and Storage.parseSave(). For checkCommandIdentity(), it tests whether the parser recognizes the identity of valid commands. For parseSave(), it tests for corruption in status symbol, argument count and date format issues.

yongkotaro

Overall, the code followed the coding standard well with appropriate naming and statements. JavaDocs were missing for only 1-2 methods.

yongkotaro · 2024-02-09T05:28:48Z

src/main/java/drew/ui/Parser.java

+
+        int inputLength = input.length();
+        Command userCommand;
+        if (inputLength == 3 && input.substring(0, 3).equalsIgnoreCase("bye")) {


Maybe could name input.substring(start, end) as "String command".

yongkotaro · 2024-02-09T05:34:12Z

src/main/java/drew/ui/Ui.java

+        System.out.println(DELIMITER);
+        System.out.println("Hello! I'm drew.Drew");
+        System.out.println("What can I do for you?");
+        System.out.println(DELIMITER);


Maybe could combine them into a constant String GREETING

yongkotaro · 2024-02-09T05:35:44Z

src/main/java/drew/task/Task.java

+    protected String description;
+    protected boolean isDone;
+
+    public Task(String description) {


Could add JavaDocs, minor issue

yongkotaro · 2024-02-09T05:37:29Z

src/main/java/drew/task/Task.java

+        return "[" + getStatusIcon() + "] " + description;
+    }
+
+    public abstract String toSaveFormatString();


Maybe could add a description.

Separated command execution logic from parser. Parser only checks for command identity now.

# Conflicts: # src/main/java/drew/Drew.java # src/main/java/drew/ui/Parser.java

Most of the classes and methods minor checkstyle issues related to: 1. Class JavaDocs 2. Import statement ordering 3. Coding standards. Fixing these issues will increase code readability, as well as ensure that styles are consistent across all files.

Asserts were added into some commands to ensure that variables are within the expected values during runtime. These changes would increase the reliability of the program.

Add asserts in commands

The following extension have been added: 1. B-Reminders 2. C-DetectDuplicates Reminders: The chatbot would remind the user of any upcoming deadlines whenever it starts. DetectDuplicates: The chatbot would prevent the user from creating tasks that already exist.

Previously, Dialog boxes would terminate after 4 lines. This commits removed max dialog box size.

damithc and others added 19 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

feat: chatbot greeting

29d602c

Added greetings

abba570

Merge commit '29d602cd98690c5dd5366a870228e8ca03a2d172'

aa4ef5b

# Conflicts: # src/main/java/Duke.java

Added echo and exit function

f0a2a7e

Added Add, List functions

a1ca0cb

Added Task Completion Tracking

8af9fa7

Added different types of tasks

d1d2e7b

Added tests

400deef

Added exception handling for: Empty arguments, illegal arguments

9f356ee

Added delete command

3697b57

Add save function

613d44a

Merge branch 'branch-Level-7'

8434e6a

Change date datatype

363e35e

Date datatype in Deadline and Event objects have been updated from String to LocalDate to support more date related functions.

Merge branch 'branch-level-8'

70dd607

Refactor storage process

826b617

Moved the save and load functions out of the main method to decouple storage functionality from main logic. Storage is now accessed with filePath and Arraylist.

Refactor Drew main method.

2dfd57a

Refactored UI, Storage, Parsing and List functionality into respective packages and classes.

maze508 reviewed Feb 5, 2024

View reviewed changes

cocoanautz added 9 commits February 5, 2024 20:00

Merge branch 'add-gradle-support' of https://github.com/nus-cs2103-AY…

817f5e6

…2324S2/ip

Updated build.gradle to support Jar.

85ff0d1

Add JavaDoc for most public methods.

7d93a60

Align all files to coding standard.

1a0c54b

Merge branch 'branch-A-CodingStandard'

c1ceabd

Merge branch 'branch-A-JavaDoc'

89d6532

Add find command

00438e1

Merge branch 'branch-level-9'

2ef2b7e

yongkotaro reviewed Feb 9, 2024

View reviewed changes

cocoanautz and others added 23 commits February 11, 2024 16:22

Add checkStyle to gradle.

5cece0f

Refactor command class

adbb8d2

Separated command execution logic from parser. Parser only checks for command identity now.

Refactor command identity check into each command class.

14f77ce

Merge branch 'refactor-commands'

f9665f4

Add GUI to the chatbot.

4ebf683

Merge branch 'branch-level-10'

0aec34f

Drew.java: Clean unused code.

2fabad4

Merge branch 'branch-A-CheckStyle'

08c988d

# Conflicts: # src/main/java/drew/Drew.java # src/main/java/drew/ui/Parser.java

Fix build.gradle

d5d8d74

Add asserts in commands

067b760

Asserts were added into some commands to ensure that variables are within the expected values during runtime. These changes would increase the reliability of the program.

Merge pull request #2 from cocoanautz/branch-A-Assertions

5ce63e8

Add asserts in commands

Add extension

f8934ab

The following extension have been added: 1. B-Reminders 2. C-DetectDuplicates Reminders: The chatbot would remind the user of any upcoming deadlines whenever it starts. DetectDuplicates: The chatbot would prevent the user from creating tasks that already exist.

Merge branch 'branch-Extension'

774233c

Update user guide

d95d186

Merge branch 'branch-A-UserGuide'

d9adefb

Update parser tests after refactor

6d46038

Merge branch 'branch-tests'

ac1d7d7

Refactor source code

7ce8f07

Remove unused imports

670241f

Update User Guide

6474052

Merge branch 'branch-A-UserGuide'

80ce277

Update dialog box size

502370c

Previously, Dialog boxes would terminate after 4 lines. This commits removed max dialog box size.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cocoanautz] ip #219

[Cocoanautz] ip #219

cocoanautz commented Jan 30, 2024 •

edited

Loading

maze508 left a comment

maze508 Feb 5, 2024

maze508 Feb 5, 2024

maze508 Feb 5, 2024

maze508 Feb 5, 2024

yongkotaro left a comment •

edited

Loading

yongkotaro Feb 9, 2024

yongkotaro Feb 9, 2024

yongkotaro Feb 9, 2024

yongkotaro Feb 9, 2024

[Cocoanautz] ip #219

Are you sure you want to change the base?

[Cocoanautz] ip #219

Conversation

cocoanautz commented Jan 30, 2024 • edited Loading

Drew, The chat-bot of all time.

maze508 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yongkotaro left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocoanautz commented Jan 30, 2024 •

edited

Loading

yongkotaro left a comment •

edited

Loading