Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for issue #133 & issue #136 #137

Merged
merged 4 commits into from
Sep 7, 2020
Merged

PR for issue #133 & issue #136 #137

merged 4 commits into from
Sep 7, 2020

Conversation

arielclj
Copy link
Contributor

Commented out prediction button and amended post request URL for predictions

@chrishkchris
Copy link
Contributor

chrishkchris commented Aug 31, 2020

@arielclj FYI, there are two prediction buttons to be commented out
prediction
b2

@arielclj
Copy link
Contributor Author

@chrishkchris Removed both buttons as requested. Code changes were tested locally.

@chrishkchris
Copy link
Contributor

When you do UI change, maybe you can get some printscreen that can show the result, thanks

@arielclj
Copy link
Contributor Author

SS
@chrishkchris Attached screenshot, as requested.

@chrishkchris
Copy link
Contributor

then should be ready for merge

@arielclj arielclj changed the title PR for issue #133 PR for issue #133 & issue #136 Sep 3, 2020
@arielclj
Copy link
Contributor Author

arielclj commented Sep 3, 2020

SS3
Uploaded PR to include refinements issue #136

Main amendments:

  • Removed 0-pointers in PlotManager.js
  • Split log data & rendering of charts by data in TrialDetails.js

@arielclj
Copy link
Contributor Author

arielclj commented Sep 4, 2020

Tested on Panda server:
for issue #136
SS4

for issue #133
SS5

@arielclj
Copy link
Contributor Author

arielclj commented Sep 7, 2020

SS6
Tested locally:
for issue #136 - trial job with >1 epoch plotted. Epoch 0 is not plotted on both graphs.

@chrishkchris
Copy link
Contributor

thanks, it looks correct now.

Ready for merge

@NLGithubWP NLGithubWP merged commit 9491460 into nusdbsystem:dev Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants