This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Porting echo command #271
Merged
Porting echo command #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2021 09:12
Referring to: https://github.com/nushell/nushell/blob/main/crates/nu-command/src/commands/core_commands/echo.rs as the original implementation.
sophiajt
reviewed
Nov 1, 2021
| _call: &Call, | ||
| input: PipelineData, | ||
| ) -> Result<PipelineData, ShellError> { | ||
| Ok(input) |
There was a problem hiding this comment.
Apologies, looks like I misspoke a little. The arguments from the rest argument are what should be turned into the output.
There was a problem hiding this comment.
No problem!
I'll deal with it in some minutes! Thanks for the feedback!
EDIT: sorry for being late, it took me more time than I originally intended.
Values to echo need to be extracted from the call, and then converted into PipelineData. I also updated the first example so that its result is a List, as in the reference implementation.
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of command
echo, assigned in #242.I also ran
cargo clippy --all, so that I was sure I didn't introduce unnecessary warnings.I'll be waiting for feedback, before going on with
format.