This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello! I have done a port of
update cells
, even though I did not sign up for it. This was really just a learning experience for me to dip my toe into contributing to nushell (I love this tool!!), but only after writing this did I notice that this port had been assigned to @kubouch (I'm assuming) in nushell/nushell#4356, although it had not been assigned in #242 which is what I had been looking at. Did not mean to not follow protocol so I don't mind closing if this is unhelpful.Tests
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code style <-- this failed herecargo build; cargo test --all --all-features
to check that all the tests passNotes
I really went into this blind and probably did some things in a non-idiomatic way, but the tests from the original are passing. There are currently two
FIXME
s [one, two] where I had questions.