Skip to content

Commit

Permalink
Change nu-deps script to not care about waves
Browse files Browse the repository at this point in the history
The script was running endlessly for me and the notion of crate waves
may be out of date, after removing them and manually aligning the output
with the relevant crate waves things went smooth.
  • Loading branch information
sholderbach committed Nov 14, 2023
1 parent 8635a78 commit d0541bc
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 19 deletions.
25 changes: 10 additions & 15 deletions make_release/nu_deps.nu
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,21 @@ def get-target-dependencies [] {
# For each Nushell crate in the first publishing wave, open its Cargo.toml and
# gather its dependencies.
def find-deps [] {
let second_wave = [ 'nu-command' ]
let third_wave = [ 'nu-cli' ]

ls crates/nu-*/Cargo.toml | get name | each {|toml|
let crate = ($toml | path dirname | path basename)
let data = (open $toml)

if not (($crate in $second_wave) or ($crate in $third_wave)) {
mut deps = []
$deps ++= ($data | get -i 'dependencies' | default {} | columns)
$deps ++= ($data | get -i 'dev-dependencies' | default {} | columns)
$deps ++= ($data | get-target-dependencies)
let $deps = ($deps
| where ($it | str starts-with 'nu-')
| where not ($it == 'nu-ansi-term'))
mut deps = []
$deps ++= ($data | get -i 'dependencies' | default {} | columns)
$deps ++= ($data | get -i 'dev-dependencies' | default {} | columns)
$deps ++= ($data | get-target-dependencies)
let $deps = ($deps
| where ($it | str starts-with 'nu-')
| where not ($it == 'nu-ansi-term'))

{
'crate': $crate
'dependencies': $deps
}
{
'crate': $crate
'dependencies': $deps
}
}
}
Expand Down
10 changes: 6 additions & 4 deletions make_release/nu_release.nu
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,21 @@ let subcrates_wave_1 = [
nu-parser,
nu-table,
nu-explore,
nu-cmd-base,
]

# This crate has a `build.rs` file and thus needs `--no-verify`
let subcrates_wave_2 = [
nu-cmd-base,
nu-cmd-lang,
nu-cmd-dataframe,
nu-cmd-extra,
nu-command,
]

let subcrates_wave_3 = [
nu-command,
nu-cmd-dataframe,
nu-cmd-extra,
nu-cli,
nu-std,
nu-lsp,

nu_plugin_query,
nu_plugin_inc,
Expand Down

0 comments on commit d0541bc

Please sign in to comment.