Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the extra menus of Nushell into custom-menus/extra/ #550

Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jul 14, 2023

related to

in this PR, i just move the extra menus from the default_config.nu configuration file of Nushell into the custom-menus/extra/ directory.

and i've also added the bindings from nushell/nushell#9676 in 71516ba as notes inline.

@fdncred
Copy link
Collaborator

fdncred commented Jul 14, 2023

I wonder if the keybindings should go with them, or if that's not important here? 🤔

@amtoine
Copy link
Member Author

amtoine commented Jul 14, 2023

I wonder if the keybindings should go with them, or if that's not important here? thinking

i've added the associated keybindings next to the menus.
do you mean they should be uncommented?

@fdncred
Copy link
Collaborator

fdncred commented Jul 14, 2023

I wonder if the keybindings should go with them, or if that's not important here? thinking

i've added the associated keybindings next to the menus. do you mean they should be uncommented?

I think how you have it is good. I may have missed it when I looked first. Thanks.

@amtoine
Copy link
Member Author

amtoine commented Jul 14, 2023

I think how you have it is good. I may have missed it when I looked first. Thanks.

no worries, great that everything is there 😊

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they shouldn't have to live in the default config eating up valuable keybindings but having them documented here is great!

@sholderbach sholderbach merged commit 832f34f into nushell:main Jul 21, 2023
@amtoine amtoine deleted the extra-menus-from-main-default-config branch July 21, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants