Script to generate the excerpt of the GH release #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add a list of PR authors so they will be shown with a profile image at the end of the GH release.
amtoine
reviewed
Jul 31, 2023
There was a problem hiding this comment.
you say "they will be shown with a profile image" but i'm not sure i see that in the output of the script 😕
am i missing something? 😇
oooh wait, you meant the real GitHub release, like this one!!
yeah we see faces at the bottom, this is nice 👌
amtoine
requested changes
Jul 31, 2023
Comment on lines
10
to
13
| let date = ( | ||
| if $date == null { (date now) - 3wk + 1day } else { $date } | ||
| | date format "%Y-%m-%d" | ||
| ) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah right I copied the code on main without looking to deep into that, and yesterday I was running it with explicit dates anyway.
There was a problem hiding this comment.
no worries 😉
the question is just: do we fix that here or in another PR? 😋
Co-authored-by: Antoine Stevan <44101798+amtoine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a list of PR authors so they will be shown with a profile
image at the end of the GH release.