add clip from standard library
#674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll land this to prepare the deprecation of |
amtoine
added a commit
to nushell/nushell
that referenced
this pull request
Nov 22, 2023
related to - #11041 - nushell/nu_scripts#674 cc/ @FMotalleb # Description reading the [frontpage of the standard library](https://github.com/nushell/nushell/blob/main/crates/nu-std/README.md#--welcome-to-the-standard-library-of-nushell--) and according to the last Nushell meeting, i has been agreed that `std clip` does not belong to the standard library 😮 - it is not written in pure Nushell and requires external dependencies which might not even work properly as in #11041 - it is not a building block to build more complex applications this PR deprecates the `std clip` command in favor of [`modules/system clip`](nushell/nu_scripts#674) for now. the `std clip` command will be removed in Nushell 0.89. # User-Facing Changes the deprecation warning:  > **Note** > the link has been changed to the `nu_scripts` in fa6c17d according to the review comments # Tests + Formatting # After Submitting this will have to be mentionned in the next release note, namely the slight differences between the two commands.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
related to - nushell#11041 - nushell/nu_scripts#674 cc/ @FMotalleb # Description reading the [frontpage of the standard library](https://github.com/nushell/nushell/blob/main/crates/nu-std/README.md#--welcome-to-the-standard-library-of-nushell--) and according to the last Nushell meeting, i has been agreed that `std clip` does not belong to the standard library 😮 - it is not written in pure Nushell and requires external dependencies which might not even work properly as in nushell#11041 - it is not a building block to build more complex applications this PR deprecates the `std clip` command in favor of [`modules/system clip`](nushell/nu_scripts#674) for now. the `std clip` command will be removed in Nushell 0.89. # User-Facing Changes the deprecation warning:  > **Note** > the link has been changed to the `nu_scripts` in fa6c17d according to the review comments # Tests + Formatting # After Submitting this will have to be mentionned in the next release note, namely the slight differences between the two commands.
kubouch
pushed a commit
to nushell/nushell
that referenced
this pull request
Jan 8, 2024
follow up to - #11097 related to - nushell/nu_scripts#674 > **Important** > wait for in between Nushell 0.88.0 and 0.89.0 # Description this PR removes the `std clip` command after it's been deprecated in #11097 😋 # User-Facing Changes `std clip` will no longer be available. # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
related to - nushell#11041 - nushell/nu_scripts#674 cc/ @FMotalleb # Description reading the [frontpage of the standard library](https://github.com/nushell/nushell/blob/main/crates/nu-std/README.md#--welcome-to-the-standard-library-of-nushell--) and according to the last Nushell meeting, i has been agreed that `std clip` does not belong to the standard library 😮 - it is not written in pure Nushell and requires external dependencies which might not even work properly as in nushell#11041 - it is not a building block to build more complex applications this PR deprecates the `std clip` command in favor of [`modules/system clip`](nushell/nu_scripts#674) for now. the `std clip` command will be removed in Nushell 0.89. # User-Facing Changes the deprecation warning:  > **Note** > the link has been changed to the `nu_scripts` in fa6c17d according to the review comments # Tests + Formatting # After Submitting this will have to be mentionned in the next release note, namely the slight differences between the two commands.
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow up to - nushell#11097 related to - nushell/nu_scripts#674 > **Important** > wait for in between Nushell 0.88.0 and 0.89.0 # Description this PR removes the `std clip` command after it's been deprecated in nushell#11097 😋 # User-Facing Changes `std clip` will no longer be available. # Tests + Formatting # After Submitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
std clipnushell#11097description
this PR is a companion to nushell/nushell#11097 and moves the
std clipcommand from the standard library to the newmodules/systemdirectory module.a new section has been added to the README of
modules/.