Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: nushell at 0.88.0 start and end are deprecated #698

Merged
merged 1 commit into from Dec 14, 2023
Merged

Fix: nushell at 0.88.0 start and end are deprecated #698

merged 1 commit into from Dec 14, 2023

Conversation

zyfmix
Copy link
Contributor

@zyfmix zyfmix commented Dec 14, 2023

This resolves: #697

@fdncred fdncred merged commit 2503468 into nushell:main Dec 14, 2023
@fdncred
Copy link
Collaborator

fdncred commented Dec 14, 2023

Thanks

fdncred added a commit that referenced this pull request Dec 14, 2023
@fdncred
Revert "Fix: nushell at 0.88.0 start and end are deprecated (#698)"
d440bfc 
This reverts commit 2503468.
@fdncred fdncred mentioned this pull request Dec 14, 2023
Closed
@fdncred
Copy link
Collaborator

fdncred commented Dec 14, 2023

This broke the script for me, reverting.

@fdncred
Copy link
Collaborator

fdncred commented Dec 14, 2023

I fixed it. Next time, test your code before submitting it please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdncred fdncred fdncred left review comments

@Bandr123 Bandr123 Bandr123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: nushell at 0.88.0 start and end are deprecated
3 participants
@zyfmix @fdncred @Bandr123