Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #460 changing .html links to .md links #1099

Merged
merged 1 commit into from Oct 10, 2023
Merged

Fixing #460 changing .html links to .md links #1099

merged 1 commit into from Oct 10, 2023

Conversation

petrisch
Copy link
Contributor

@petrisch petrisch commented Oct 6, 2023

This should fix at least one part of my naive issue so that we can close it.

@amtoine
Copy link
Member

amtoine commented Oct 6, 2023

would this PR completely close #460? 😋

@petrisch
Copy link
Contributor Author

petrisch commented Oct 9, 2023

@amtoine no as i said only partially.
But since i created it and there really shouldn't be two issues in one, we should close it.
But you can also keep it and i will fix it later.

sholderbach
sholderbach approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@sholderbach sholderbach left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! (I don't mind keeping the issue open for the rest of the inconsistencies)

@sholderbach sholderbach merged commit fae6650 into nushell:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholderbach sholderbach sholderbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petrisch @amtoine @sholderbach