Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename def-env to def --env #1155

Merged
merged 3 commits into from Nov 26, 2023
Merged

Rename def-env to def --env #1155

merged 3 commits into from Nov 26, 2023

Conversation

arnau
Copy link
Contributor

@arnau arnau commented Nov 25, 2023

This PR changes all def-env to def --env. def-env was deprecated in 0.87.

There are a few commits:

  • Rename def-env to the new def --env: Changes the book in English
  • (de) Rename def-env to the new def --env: Changes the book in German (I don't speak German)
  • (zh-CN) Rename def-env to the new def --env: Changes the book in Chinese (I don't speak Chinese)
  • Update command docs. Change after running nu make_docs.nu
  • Add docs for the experimental command category. Please review this bit. I was not expecting nu make_docs.nu to generate these files. It seems like it's due to a plugin I have installed which makes me question whether make_docs.nu should filter plugins out?.
╭────────────────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ version            │ 0.87.1                                                                                                                │
│ branch             │                                                                                                                       │
│ commit_hash        │ 3d631490bc17cfef2944072f9b7869cd9cac1e7b                                                                              │
│ build_os           │ macos-aarch64                                                                                                         │
│ build_target       │ aarch64-apple-darwin                                                                                                  │
│ rust_version       │ rustc 1.71.1 (eb26296b5 2023-08-03)                                                                                   │
│ rust_channel       │ 1.71.1-aarch64-apple-darwin                                                                                           │
│ cargo_version      │ cargo 1.71.1 (7f1d04c00 2023-07-29)                                                                                   │
│ build_time         │ 2023-11-25 17:11:03 +00:00                                                                                            │
│ build_rust_channel │ release                                                                                                               │
│ allocator          │ mimalloc                                                                                                              │
│ features           │ dataframe, default, extra, sqlite, trash, which, zip                                                                  │
│ installed_plugins  │ custom-value generate, custom-value generate2, custom-value update, from eml, from ics, from ini, from vcf, gstat,    │
│                    │ inc, query, query json, query web, query xml                                                                          │
╰────────────────────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯```

@amtoine
Copy link
Member

amtoine commented Nov 25, 2023

@arnau
could you revert the changes to the commands/ directory so that we keep this PR focused on the def-env fix? 😇

let's say the diff is... huge 😉

@arnau
Copy link
Contributor Author

arnau commented Nov 25, 2023

reverted 👍

book/modules.md Outdated Show resolved Hide resolved
book/modules.md Outdated Show resolved Hide resolved
de/book/hooks.md Outdated Show resolved Hide resolved
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for going through these, just a few remarks 😉

@arnau arnau force-pushed the fix-def-env branch 2 times, most recently from fabffed to 0a560c0 Compare November 25, 2023 18:15
Signed-off-by: Arnau Siches <asiches@gmail.com>
Signed-off-by: Arnau Siches <asiches@gmail.com>
Signed-off-by: Arnau Siches <asiches@gmail.com>
@arnau
Copy link
Contributor Author

arnau commented Nov 25, 2023

@amtoine could you have a fresh look please? I've done it now from scratch without git hooks. All markdown issues are gone as far as I can tell.

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh yeah, looks much better, thanks a lot 🙏

hopefully the last def-env are gone for good 😌

@amtoine amtoine merged commit 625e043 into nushell:main Nov 26, 2023
2 checks passed
@arnau arnau deleted the fix-def-env branch November 26, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants