Input output checking (#9680)

# Description

This PR tights input/output type-checking a bit more. There are a lot of
commands that don't have correct input/output types, so part of the
effort is updating them.

This PR now contains updates to commands that had wrong input/output
signatures. It doesn't add examples for these new signatures, but that
can be follow-up work.

# User-Facing Changes

BREAKING CHANGE BREAKING CHANGE

This work enforces many more checks on pipeline type correctness than
previous nushell versions. This strictness may uncover incompatibilities
in existing scripts or shortcomings in the type information for internal
commands.

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->

crates/nu-cmd-extra/src/extra/bits/and.rs

@@ -15,7 +15,13 @@ impl Command for BitsAnd {
 
     fn signature(&self) -> Signature {
         Signature::build("bits and")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required(
                 "target",

crates/nu-cmd-extra/src/extra/bits/not.rs

@@ -16,7 +16,13 @@ impl Command for BitsNot {
 
     fn signature(&self) -> Signature {
         Signature::build("bits not")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .switch(
                 "signed",

crates/nu-cmd-extra/src/extra/bits/or.rs

@@ -15,7 +15,13 @@ impl Command for BitsOr {
 
     fn signature(&self) -> Signature {
         Signature::build("bits or")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required(
                 "target",

crates/nu-cmd-extra/src/extra/bits/rotate_left.rs

@@ -18,7 +18,13 @@ impl Command for BitsRol {
 
     fn signature(&self) -> Signature {
         Signature::build("bits rol")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required("bits", SyntaxShape::Int, "number of bits to rotate left")
             .switch(

crates/nu-cmd-extra/src/extra/bits/rotate_right.rs

@@ -18,7 +18,13 @@ impl Command for BitsRor {
 
     fn signature(&self) -> Signature {
         Signature::build("bits ror")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required("bits", SyntaxShape::Int, "number of bits to rotate right")
             .switch(

crates/nu-cmd-extra/src/extra/bits/shift_left.rs

@@ -18,7 +18,13 @@ impl Command for BitsShl {
 
     fn signature(&self) -> Signature {
         Signature::build("bits shl")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required("bits", SyntaxShape::Int, "number of bits to shift left")
             .switch(

crates/nu-cmd-extra/src/extra/bits/shift_right.rs

@@ -18,7 +18,13 @@ impl Command for BitsShr {
 
     fn signature(&self) -> Signature {
         Signature::build("bits shr")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required("bits", SyntaxShape::Int, "number of bits to shift right")
             .switch(

crates/nu-cmd-extra/src/extra/bits/xor.rs

@@ -15,7 +15,13 @@ impl Command for BitsXor {
 
     fn signature(&self) -> Signature {
         Signature::build("bits xor")
-            .input_output_types(vec![(Type::Int, Type::Int)])
+            .input_output_types(vec![
+                (Type::Int, Type::Int),
+                (
+                    Type::List(Box::new(Type::Int)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .required(
                 "target",

crates/nu-cmd-extra/src/extra/bytes/length.rs

@@ -16,7 +16,13 @@ impl Command for BytesLen {
 
     fn signature(&self) -> Signature {
         Signature::build("bytes length")
-            .input_output_types(vec![(Type::Binary, Type::Int)])
+            .input_output_types(vec![
+                (Type::Binary, Type::Int),
+                (
+                    Type::List(Box::new(Type::Binary)),
+                    Type::List(Box::new(Type::Int)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .rest(
                 "rest",

crates/nu-cmd-extra/src/extra/bytes/remove.rs

@@ -30,7 +30,10 @@ impl Command for BytesRemove {
 
     fn signature(&self) -> Signature {
         Signature::build("bytes remove")
-            .input_output_types(vec![(Type::Binary, Type::Binary)])
+            .input_output_types(vec![
+                (Type::Binary, Type::Binary),
+                (Type::Table(vec![]), Type::Table(vec![])),
+            ])
             .required("pattern", SyntaxShape::Binary, "the pattern to find")
             .rest(
                 "rest",

crates/nu-cmd-extra/src/extra/bytes/replace.rs

@@ -30,7 +30,10 @@ impl Command for BytesReplace {
 
     fn signature(&self) -> Signature {
         Signature::build("bytes replace")
-            .input_output_types(vec![(Type::Binary, Type::Binary)])
+            .input_output_types(vec![
+                (Type::Binary, Type::Binary),
+                (Type::Table(vec![]), Type::Table(vec![])),
+            ])
             .required("find", SyntaxShape::Binary, "the pattern to find")
             .required("replace", SyntaxShape::Binary, "the replacement pattern")
             .rest(

crates/nu-cmd-extra/src/extra/math/cos.rs

@@ -13,7 +13,13 @@ impl Command for SubCommand {
     fn signature(&self) -> Signature {
         Signature::build("math cos")
             .switch("degrees", "Use degrees instead of radians", Some('d'))
-            .input_output_types(vec![(Type::Number, Type::Float)])
+            .input_output_types(vec![
+                (Type::Number, Type::Float),
+                (
+                    Type::List(Box::new(Type::Number)),
+                    Type::List(Box::new(Type::Float)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .category(Category::Math)
     }

crates/nu-cmd-extra/src/extra/math/sin.rs

@@ -13,7 +13,13 @@ impl Command for SubCommand {
     fn signature(&self) -> Signature {
         Signature::build("math sin")
             .switch("degrees", "Use degrees instead of radians", Some('d'))
-            .input_output_types(vec![(Type::Number, Type::Float)])
+            .input_output_types(vec![
+                (Type::Number, Type::Float),
+                (
+                    Type::List(Box::new(Type::Number)),
+                    Type::List(Box::new(Type::Float)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .category(Category::Math)
     }

crates/nu-cmd-extra/src/extra/math/tan.rs

@@ -13,7 +13,13 @@ impl Command for SubCommand {
     fn signature(&self) -> Signature {
         Signature::build("math tan")
             .switch("degrees", "Use degrees instead of radians", Some('d'))
-            .input_output_types(vec![(Type::Number, Type::Float)])
+            .input_output_types(vec![
+                (Type::Number, Type::Float),
+                (
+                    Type::List(Box::new(Type::Number)),
+                    Type::List(Box::new(Type::Float)),
+                ),
+            ])
             .vectorizes_over_list(true)
             .category(Category::Math)
     }

crates/nu-cmd-extra/tests/commands/bytes/starts_with.rs

@@ -21,7 +21,7 @@ fn basic_string_fails() {
         "#
     );
 
-    assert!(actual.err.contains("Input type not supported"));
+    assert!(actual.err.contains("command doesn't support"));
     assert_eq!(actual.out, "");
 }
 

crates/nu-cmd-lang/src/core_commands/collect.rs

@@ -16,7 +16,7 @@ impl Command for Collect {
 
     fn signature(&self) -> Signature {
         Signature::build("collect")
-            .input_output_types(vec![(Type::List(Box::new(Type::Any)), Type::Any)])
+            .input_output_types(vec![(Type::Any, Type::Any)])
             .required(
                 "closure",
                 SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),

crates/nu-command/src/conversions/into/decimal.rs

@@ -17,15 +17,21 @@ impl Command for SubCommand {
     fn signature(&self) -> Signature {
         Signature::build("into decimal")
             .input_output_types(vec![
+                (Type::Int, Type::Number),
                 (Type::String, Type::Number),
                 (Type::Bool, Type::Number),
                 (Type::Table(vec![]), Type::Table(vec![])),
+                (
+                    Type::List(Box::new(Type::Any)),
+                    Type::List(Box::new(Type::Number)),
+                ),
             ])
             .rest(
                 "rest",
                 SyntaxShape::CellPath,
                 "for a data structure input, convert data at the given cell paths",
             )
+            .allow_variants_without_examples(true)
             .category(Category::Conversions)
     }
 

crates/nu-command/src/conversions/into/int.rs

@@ -36,10 +36,17 @@ impl Command for SubCommand {
                 (Type::Bool, Type::Int),
                 // Unix timestamp in nanoseconds
                 (Type::Date, Type::Int),
+                (Type::Duration, Type::Int),
                 // TODO: Users should do this by dividing a Filesize by a Filesize explicitly
                 (Type::Filesize, Type::Int),
+                (Type::Table(vec![]), Type::Table(vec![])),
+                (
+                    Type::List(Box::new(Type::Any)),
+                    Type::List(Box::new(Type::Int)),
+                ),
             ])
             .vectorizes_over_list(true)
+            .allow_variants_without_examples(true)
             .named("radix", SyntaxShape::Number, "radix of integer", Some('r'))
             .switch("little-endian", "use little-endian byte decoding", None)
             .rest(

crates/nu-command/src/conversions/into/string.rs

@@ -40,6 +40,10 @@ impl Command for SubCommand {
                 (Type::Bool, Type::String),
                 (Type::Filesize, Type::String),
                 (Type::Date, Type::String),
+                (
+                    Type::List(Box::new(Type::Any)),
+                    Type::List(Box::new(Type::String)),
+                ),
             ])
             .allow_variants_without_examples(true) // https://github.com/nushell/nushell/issues/7032
             .rest(

crates/nu-command/src/env/load_env.rs

@@ -19,7 +19,10 @@ impl Command for LoadEnv {
 
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build("load-env")
-            .input_output_types(vec![(Type::Record(vec![]), Type::Nothing)])
+            .input_output_types(vec![
+                (Type::Record(vec![]), Type::Nothing),
+                (Type::Nothing, Type::Nothing),
+            ])
             .allow_variants_without_examples(true)
             .optional(
                 "update",

crates/nu-command/src/filters/append.rs

@@ -16,11 +16,15 @@ impl Command for Append {
 
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build("append")
-            .input_output_types(vec![(
-                Type::List(Box::new(Type::Any)),
-                Type::List(Box::new(Type::Any)),
-            )])
+            .input_output_types(vec![
+                (
+                    Type::List(Box::new(Type::Any)),
+                    Type::List(Box::new(Type::Any)),
+                ),
+                (Type::Record(vec![]), Type::Table(vec![])),
+            ])
             .required("row", SyntaxShape::Any, "the row, list, or table to append")
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }
 

crates/nu-command/src/filters/each.rs

@@ -41,13 +41,15 @@ with 'transpose' first."#
                     Type::List(Box::new(Type::Any)),
                 ),
                 (Type::Table(vec![]), Type::List(Box::new(Type::Any))),
+                (Type::Any, Type::Any),
             ])
             .required(
                 "closure",
                 SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
                 "the closure to run",
             )
             .switch("keep-empty", "keep empty result cells", Some('k'))
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }
 

crates/nu-command/src/filters/find.rs

@@ -29,7 +29,7 @@ impl Command for Find {
                     Type::List(Box::new(Type::Any)),
                     Type::List(Box::new(Type::Any)),
                 ),
-                (Type::String, Type::String),
+                (Type::String, Type::Any),
                 (
                     // For find -p
                     Type::Table(vec![]),

crates/nu-command/src/filters/first.rs

@@ -33,12 +33,14 @@ impl Command for First {
                     Type::Any,
                 ),
                 (Type::Binary, Type::Binary),
+                (Type::Range, Type::Any),
             ])
             .optional(
                 "rows",
                 SyntaxShape::Int,
                 "starting from the front, the number of rows to return",
             )
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }
 

crates/nu-command/src/filters/get.rs

@@ -34,6 +34,7 @@ If multiple cell paths are given, this will produce a list of values."#
                     Type::Any,
                 ),
                 (Type::Table(vec![]), Type::Any),
+                (Type::Record(vec![]), Type::Any),
             ])
             .required(
                 "cell_path",
@@ -51,6 +52,7 @@ If multiple cell paths are given, this will produce a list of values."#
                 "get path in a case sensitive manner",
                 Some('s'),
             )
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }
 

crates/nu-command/src/filters/insert.rs

@@ -19,6 +19,10 @@ impl Command for Insert {
             .input_output_types(vec![
                 (Type::Record(vec![]), Type::Record(vec![])),
                 (Type::Table(vec![]), Type::Table(vec![])),
+                (
+                    Type::List(Box::new(Type::Any)),
+                    Type::List(Box::new(Type::Any)),
+                ),
             ])
             .required(
                 "field",
@@ -30,6 +34,7 @@ impl Command for Insert {
                 SyntaxShape::Any,
                 "the new value to give the cell(s)",
             )
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }
 

crates/nu-command/src/filters/select.rs

@@ -21,6 +21,7 @@ impl Command for Select {
             .input_output_types(vec![
                 (Type::Record(vec![]), Type::Record(vec![])),
                 (Type::Table(vec![]), Type::Table(vec![])),
+                (Type::List(Box::new(Type::Any)), Type::Any),
             ])
             .switch(
                 "ignore-errors",
@@ -32,6 +33,7 @@ impl Command for Select {
                 SyntaxShape::CellPath,
                 "the columns to select from the table",
             )
+            .allow_variants_without_examples(true)
             .category(Category::Filters)
     }