Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope commands appear as filters in help #10802

Closed
NotTheDr01ds opened this issue Oct 21, 2023 · 2 comments · Fixed by #10892
Closed

scope commands appear as filters in help #10802

NotTheDr01ds opened this issue Oct 21, 2023 · 2 comments · Fixed by #10892
Labels
documentation issues relating to documentation good first issue Good for newcomers
Milestone

Comments

@NotTheDr01ds
Copy link
Contributor

Describe the bug

Nitpick and minor, but while I'm writing up a few issues and thinking about it, I noticed that all of the scope commands are categorized as filters in help commands.

How to reproduce

help commands | where name =~ "scope" | select category

Returns:

category
core
filters
filters
filters
filters
filters
filters

Expected behavior

Shouldn't all of these (including the root scope) be categorized as debug?

They definitely feel wrongly categorized as filters since not one of them takes any input on the pipeline.

Screenshots

No response

Configuration

key value
version 0.86.0
branch
commit_hash 5d8763e
build_os linux-x86_64
build_target x86_64-unknown-linux-gnu
rust_version rustc 1.71.1 (eb26296b5 2023-08-03)
rust_channel 1.71.1-x86_64-unknown-linux-gnu
cargo_version cargo 1.71.1 (7f1d04c00 2023-07-29)
build_time 2023-10-17 17:14:05 +00:00
build_rust_channel release
allocator mimalloc
features dataframe, default, extra, sqlite, static-link-openssl, trash, which, zip
installed_plugins

Additional context

No response

@NotTheDr01ds NotTheDr01ds added the needs-triage An issue that hasn't had any proper look label Oct 21, 2023
@fdncred
Copy link
Collaborator

fdncred commented Oct 21, 2023

I'm not sure debug is the right category but I don't think filter is either. Maybe just core?

@amtoine
Copy link
Member

amtoine commented Oct 21, 2023

maybe just core 👍

@amtoine amtoine added good first issue Good for newcomers documentation issues relating to documentation and removed needs-triage An issue that hasn't had any proper look labels Oct 21, 2023
@hustcer hustcer added this to the v0.87.0 milestone Oct 31, 2023
hardfau1t pushed a commit to hardfau1t/nushell that referenced this issue Dec 14, 2023
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues relating to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants