'url join' ignores username when password is null

[richardwesthaver]

Describe the bug

https://discord.com/channels/601130461678272522/614593951969574961/1201692172823298108

The url join command currently ignores username when password is null

How to reproduce

'https://github.com/' | url parse | update username 'git' | update scheme ssh | url join
# => ssh://github.com/

Expected behavior

expected output: "ssh://git@github.com/"

Screenshots

No response

Configuration

key	value
version	0.89.0
branch
commit_hash
build_os	linux-x86_64
build_target	x86_64-unknown-linux-gnu
rust_version	rustc 1.77.0-nightly (30dfb9e04 2024-01-14)
rust_channel	nightly-x86_64-unknown-linux-gnu
cargo_version	cargo 1.77.0-nightly (84976cd69 2024-01-12)
build_time	2024-01-20 19:04:09 -05:00
build_rust_channel	release
allocator	mimalloc
features	dataframe, default, sqlite, trash, which, zip
installed_plugins	port list

Additional context

No response

[richardwesthaver]

likely culprit:

nushell/crates/nu-command/src/network/url/join.rs

Lines 319 to 357 in 175dab4

	pub fn to_url(&self, span: Span) -> Result<String, ShellError> {
	let mut user_and_pwd: String = String::from("");
	if let Some(usr) = &self.username {
	if let Some(pwd) = &self.password {
	user_and_pwd = format!("{usr}:{pwd}@");
	}
	}
	let scheme_result = match &self.scheme {
	Some(s) => Ok(s),
	None => Err(UrlComponents::generate_shell_error_for_missing_parameter(
	String::from("scheme"),
	span,
	)),
	};
	let host_result = match &self.host {
	Some(h) => Ok(h),
	None => Err(UrlComponents::generate_shell_error_for_missing_parameter(
	String::from("host"),
	span,
	)),
	};
	Ok(format!(
	"{}://{}{}{}{}{}{}",
	scheme_result?,
	user_and_pwd,
	host_result?,
	self.port
	.map(|p| format!(":{p}"))
	.as_deref()
	.unwrap_or_default(),
	self.path.as_deref().unwrap_or_default(),
	self.query.as_deref().unwrap_or_default(),
	self.fragment.as_deref().unwrap_or_default()
	))
	}

I'll try to remember to PR when I got time :)

[richardwesthaver]

fixed by: richardwesthaver@15a2c67