Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume variables are valid in nu-highlight #13139

Open
NotTheDr01ds opened this issue Jun 12, 2024 · 1 comment
Open

Assume variables are valid in nu-highlight #13139

NotTheDr01ds opened this issue Jun 12, 2024 · 1 comment
Labels
enhancement New feature or request needs-triage An issue that hasn't had any proper look

Comments

@NotTheDr01ds
Copy link
Contributor

NotTheDr01ds commented Jun 12, 2024 •
edited
Loading

Related problem

When passing history items to nu-highlight for formatting in fzf, variable names always show error-red, even when they are defined in the current shell. This is because fzf --preview is running nu-highlight in a different nu instance.

Describe the solution you'd like

Either assume that variable names are valid or provide a flag that suppresses error highlighting for "invalid" string names

Describe alternatives you've considered

No response

Additional context and details

No response
@NotTheDr01ds NotTheDr01ds added enhancement New feature or request needs-triage An issue that hasn't had any proper look labels Jun 12, 2024
@fdncred
Copy link
Collaborator

fdncred commented Jun 12, 2024

I'm not having issues. my variables seem to be colored right aka the default colors.
image

These are my colors with my theme.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-triage An issue that hasn't had any proper look
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fdncred @NotTheDr01ds