Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert span-less errors to spanned errors #224

Closed
sophiajt opened this issue Jul 28, 2019 · 7 comments
Closed

Convert span-less errors to spanned errors #224

sophiajt opened this issue Jul 28, 2019 · 7 comments
Labels
good first issue Good for newcomers

Comments

@sophiajt
Copy link
Member

We're due a good pass over the code to remove most of the string errors and replace them with errors that point to spans (including possibly origin spans).

This is a placeholder, but should be replaced with the locations of the remaining span-less errors.

@sophiajt
Copy link
Member Author

sophiajt commented Aug 2, 2019

This is basically going through and looking at each of the ShellError::untagged_runtime_error and trying to replace the ones we can with ShellError::labeled_error, if possible.

@sophiajt sophiajt added the good first issue Good for newcomers label Aug 2, 2019
@humancalico
Copy link

Hey! @jonathandturner Can I take this issue?

@sophiajt
Copy link
Member Author

sophiajt commented Oct 7, 2019

@akshat2654 - please do! You don't need to do them all at once. You can file a PR with batches of fixes, if you like.

@Falcz
Copy link

Falcz commented Oct 15, 2019

Looks like this issue is outdated as of #728 - ShellError::string has been replaced with ShellError::untagged_runtime_error

@sophiajt
Copy link
Member Author

Thanks, I'll update

@coderkalyan
Copy link

Hi! @jonathandturner is there still stuff to do, that I can work on here? If so, I'd like to help, I'll probably do it one at a time since I'm new to the codebase

@sophiajt
Copy link
Member Author

Looks like almost all of these that can be converted have been converted.

Closing this, but we should keep a watch for any that we missed.

Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this issue Jan 27, 2023
Document Visual C++ requirement on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants