Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which #26

Closed
wycats opened this issue May 24, 2019 · 1 comment
Closed

which #26

wycats opened this issue May 24, 2019 · 1 comment
Labels
good first issue Good for newcomers
Projects

Comments

@wycats
Copy link
Contributor

wycats commented May 24, 2019

Should be able to handle builtins. I think something like the where.exe approach is nice here -- a list of all of the results and if you want the top you do | first 1

@wycats wycats created this issue from a note in Tasks (Infrastructure) May 24, 2019
@sophiajt sophiajt added the good first issue Good for newcomers label Aug 2, 2019
@sophiajt
Copy link
Member

First pass: #267

Not sure about returning multiple results, but we can work on extending it further.

Tasks automation moved this from Infrastructure to Done Aug 10, 2019
elferherrera pushed a commit to elferherrera/nushell that referenced this issue Feb 7, 2022
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this issue Jan 27, 2023
fdncred added a commit that referenced this issue Aug 18, 2023
Description

This PR allows ints to be used as cell paths.

### Before
```nushell
❯ let index = 0
❯ locations | select $index
Error: nu::shell::cant_convert

  × Can't convert to cell path.
   ╭─[entry #26:1:1]
 1 │ locations | select $index
   ·                    ───┬──
   ·                       ╰── can't convert int to cell path
   ╰────
```

### After
```nushell
❯ let index = 0
❯ locations | select $index
╭#┬───────location────────┬city_column┬state_column┬country_column┬lat_column┬lon_column╮
│0│http://ip-api.com/json/│city       │region      │countryCode   │lat       │lon       │
╰─┴───────────────────────┴───────────┴────────────┴──────────────┴──────────┴──────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Tasks
  
Done
Development

No branches or pull requests

2 participants