Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an alternative to reqwest #342

Closed
orf opened this issue Aug 23, 2019 · 4 comments · Fixed by #397
Closed

Consider an alternative to reqwest #342

orf opened this issue Aug 23, 2019 · 4 comments · Fixed by #397

Comments

@orf
Copy link
Contributor

orf commented Aug 23, 2019

Reqwest is used in one major place: open, to obviously support opening remote URL's.

However reqwest the dependency adds 68 dependencies to the build, and about 4mb to the release binary size.

reqwest pulls in a lot of the tokio stack, and seems to support things like HTTP/2. Do we really need this? Is there a smaller, perhaps simpler library we could use instead?

@sophiajt
Copy link
Member

One possibility would be Surf (https://blog.yoshuawuyts.com/surf/) or something like it

@jbcden
Copy link

jbcden commented Aug 24, 2019

I would like to try working on this if that is ok. I am hoping to try and open a PR tomorrow! I am currently trying to go with surf as mentioned above.

@sophiajt
Copy link
Member

@jbcden - sounds good! you can see a PR I started (#397) but it needs to work to finish it

@jbcden
Copy link

jbcden commented Aug 25, 2019

@jonathandturner Sounds good! I am looking at it now! I started to look at this yesterday but your branch is a fair bit further along!

elferherrera pushed a commit to elferherrera/nushell that referenced this issue Feb 7, 2022
Co-authored-by: Stefan Stanciulescu <contact@stefanstanciulescu.com>
kubouch pushed a commit that referenced this issue Feb 7, 2022
Co-authored-by: Stefan Stanciulescu <contact@stefanstanciulescu.com>
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this issue Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants