Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up- and Down- Arrow should consider entered text #465

Closed
Flare576 opened this issue Aug 26, 2019 · 12 comments
Closed

Up- and Down- Arrow should consider entered text #465

Flare576 opened this issue Aug 26, 2019 · 12 comments
Labels
upstream problem with upstream dependency

Comments

@Flare576
Copy link
Contributor

When I type in a partial command and press ⬆️, I expect to only see historical commands starting with my partial. Example:

> cd /a/really/long/path
> ls
> cd /another/really/long/path
> ls
> cd /a/ ⬆️

I'd expect the line to now have cd /a/really/long/path, but it actually has ls

@Porges
Copy link
Contributor

Porges commented Aug 26, 2019

This will be a feature for rustyline.

@sophiajt sophiajt added the upstream problem with upstream dependency label Aug 26, 2019
@wycats
Copy link
Contributor

wycats commented Aug 27, 2019

@Flare576 Does the right-arrow completion work for you? Or ctrl-r?

I agree that this would be nice too, and also that it's an upstream issue.

@provjeremys
Copy link

@wycats Right-arrow completion does take the value displayed in white and enter it as the current command. I'm 99.9% sure we're on the same page, but just to future-proof this issue: my request would be to, essentially, filter the history based on the already entered partial command, not just maintain the right-arrow functionality.

@oberien
Copy link

oberien commented Aug 1, 2020

Is there an update on this? I'm very used to typing the beginning of a command and using arrow-up a few times to find a command in my history from the zsh feature and would love to see it in nushell.

If you can give me some hints I'm willing to implement this feature and create a PR.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 1, 2020

@oberien - we currently use https://github.com/kkawakam/rustyline to do our line editing. If it gets implemented there, we should be able to add it nushell. You might want to file an issue on that repo and see if it's being worked on. The bonus is that other people using rustyline would also benefit.

@deathtrip
Copy link

Why won't they accept the pull request?
Maybe nu should (temporarily?) switch to a rustyline fork.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale used for marking issues and prs as stale label Jun 24, 2021
@taylorthurlow
Copy link

!notstale

@github-actions github-actions bot removed the Stale used for marking issues and prs as stale label Jul 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

This issue is being marked stale because it has been open for 90 days without activity. If you feel that this is in error, please comment below and we will keep it marked as active.

@github-actions github-actions bot added the Stale used for marking issues and prs as stale label Oct 6, 2021
@Porges
Copy link
Contributor

Porges commented Oct 6, 2021

This is not stale.

@github-actions github-actions bot removed the Stale used for marking issues and prs as stale label Oct 7, 2021
elferherrera pushed a commit to elferherrera/nushell that referenced this issue Feb 7, 2022
* Sort default context items categorically

* Separate commands in multiple statements

* Use curly braces instead of square brackets

This prevents undesired reformatting.
kubouch pushed a commit that referenced this issue Feb 7, 2022
* Sort default context items categorically

* Separate commands in multiple statements

* Use curly braces instead of square brackets

This prevents undesired reformatting.
@sholderbach
Copy link
Member

Solved with the history traversal behavior of reedline

Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this issue Jan 27, 2023
* Upgrade vuepress to v2 and add dark mode support

* Fix code snippets importing

* Fix nav item titles

* Fix some broken tables

* Fix blog, serch and command reference

* Fix doc building for vuepress-next, avoid using angle brackets

* Fix broken tables
@felschr
Copy link

felschr commented Mar 17, 2023

I have slightly different case, where I'd like arrow up to match commands that contain the text I've entered, not just commands that start with the text.
e.g. when I enter rebuild, then press arrow up, I'd expect it to match sudo nixos-rebuild switch from my history.

I'm currently running nushell 0.71.0, but I also couldn't find any mention of this feature in any following release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream problem with upstream dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants