Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: indexes of 1000+ row table wrap around to 0 after every 1000 #6840

Closed
webbedspace opened this issue Oct 21, 2022 · 2 comments · Fixed by #6850
Closed

table: indexes of 1000+ row table wrap around to 0 after every 1000 #6840

webbedspace opened this issue Oct 21, 2022 · 2 comments · Fixed by #6850
Labels
🐛 bug Something isn't working tabled Issues about our new table renderer (tabled)
Milestone
v0.71.0

Comments

@webbedspace
Copy link
Contributor

webbedspace commented Oct 21, 2022 •
edited

Describe the bug

When displaying a table with 1000+ rows, the indexes will wrap around back to 0 after index number 999.

How to reproduce

This is from running mame -listmedia | from ssv. mame -listmedia returns a 44,308-line SSV file.
image

Expected behavior

I expect the indexes to increment accurately. Note that the indexes are actually correct in the data structure itself: mame -listmedia | from ssv | get 19001 works correctly.

Screenshots

No response

Configuration

key value
version 0.70.0
branch
commit_hash 9ef65dc
build_os windows-x86_64
build_target x86_64-pc-windows-msvc
rust_version rustc 1.64.0 (a55dd71d5 2022-09-19)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.64.0 (387270bc7 2022-09-16)
pkg_version 0.70.0
build_time 2022-10-18 18:55:02 +00:00
build_rust_channel release
features database, dataframe, default, trash, which, zip
installed_plugins

Additional context

No response
@fdncred
Copy link
Collaborator

fdncred commented Oct 21, 2022 •
edited

It didn't used to work like that. It would just go to 1000. I wonder when it changed. @zhiburt do you think moving to tabled caused this?

@fdncred fdncred added 🐛 bug Something isn't working tabled Issues about our new table renderer (tabled) labels Oct 21, 2022
@zhiburt
Copy link
Contributor

zhiburt commented Oct 21, 2022 •
edited

Thanks for opening @webbedspace

I actually noticed it last week locally but after pulling main (or something like it) it was fixed (or reverse not sure).
Not sure.

1..100000

image

zhiburt added a commit to zhiburt/nushell that referenced this issue Oct 21, 2022
@zhiburt
table/ Fix paging indexing
0b77292 
close nushell#6840

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
@zhiburt zhiburt mentioned this issue Oct 21, 2022
Merged
sholderbach pushed a commit that referenced this issue Oct 21, 2022
@zhiburt
table/ Fix paging indexing (#6850)
46c0d29 
* table/ Fix paging indexing

close #6840

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>

* Add test for pagging with row_overlapping

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
@hustcer hustcer added this to the v0.71.0 milestone Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working tabled Issues about our new table renderer (tabled)
Projects
None yet
Milestone
v0.71.0
Development

Successfully merging a pull request may close this issue.

table/ Fix paging indexing zhiburt/nushell
4 participants
@webbedspace @fdncred @hustcer @zhiburt