Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab completion doesn't put ` tildes around filenames with parentheses #7706

Closed
webbedspace opened this issue Jan 7, 2023 · 0 comments · Fixed by #7712
Closed

Tab completion doesn't put ` tildes around filenames with parentheses #7706

webbedspace opened this issue Jan 7, 2023 · 0 comments · Fixed by #7712
Milestone
v0.74.0

Comments

@webbedspace
Copy link
Contributor

Describe the bug

Filenames with parentheses need ` tildes around them, but they aren't considered as such by tab completion (of files in the current directory).

How to reproduce

image
As you can see, the filename above doesn't function despite being produced by tab completion.

Expected behavior

See above.

Screenshots

No response

Configuration

key value
version 0.73.0
branch main
commit_hash 1291b64
build_os windows-x86_64
build_target x86_64-pc-windows-msvc
rust_version rustc 1.65.0 (897e37553 2022-11-02)
rust_channel 1.65.0-x86_64-pc-windows-msvc
cargo_version cargo 1.65.0 (4bc8f24d3 2022-10-20)
pkg_version 0.73.0
build_time 2022-12-21 16:52:27 +10:00
build_rust_channel release
features database, default, trash, which, zip
installed_plugins

Additional context

No response
@WindSoilder WindSoilder mentioned this issue Jan 9, 2023
Merged
sholderbach added a commit that referenced this issue Jan 10, 2023
@WindSoilder @sholderbach
Auto-Completion: put ` tildes around filenames with parentheses (#7712)
f609a4f 
# Description

Fixes: #7706

# User-Facing Changes


![img](https://user-images.githubusercontent.com/22256154/211286663-3d07a650-5e2d-406e-99f6-cff90dba352b.png)


# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
@hustcer hustcer added this to the v0.74 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.74.0
Development

Successfully merging a pull request may close this issue.

Auto-Completion: put ` tildes around filenames with parentheses WindSoilder/nushell
2 participants
@webbedspace @hustcer