Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more fields to scope commands #10045

Merged
merged 4 commits into from Aug 18, 2023
Merged

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Aug 18, 2023

Description

  • scope aliases: Adds the ID of the aliased call so that you can go and look up info about the aliased command
  • scope variables: Adds is_const field to denote whether a variable is a constant or not

User-Facing Changes

A few more fields to scope commands which go together with the recent additions.

Tests + Formatting

After Submitting

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this PR 👍
more information is good 👌

@kubouch kubouch merged commit 2aa4cd5 into nushell:main Aug 18, 2023
19 checks passed
@kubouch kubouch deleted the scope-more branch August 18, 2023 17:47
@sholderbach sholderbach added the pr:release-note-mention Addition/Improvement to be mentioned in the release notes label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:release-note-mention Addition/Improvement to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants