Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively export constants from modules #10049

Merged
merged 15 commits into from Aug 20, 2023
Merged

Recursively export constants from modules #10049

merged 15 commits into from Aug 20, 2023

Commits on Aug 18, 2023

  1. Rename module's "variables" to "constants"

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    79a3822 View commit details
    Browse the repository at this point in the history

  2. Rename variables

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    245562f View commit details
    Browse the repository at this point in the history

  3. Add additional check for constant

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ac1ea65 View commit details
    Browse the repository at this point in the history

  4. Remove comment

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b5ff1c1 View commit details
    Browse the repository at this point in the history

  5. Remove comments

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    410a0c7 View commit details
    Browse the repository at this point in the history

  6. Make const imports recursive with use

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    720c9f6 View commit details
    Browse the repository at this point in the history

  7. Add note

    @kubouch
    kubouch committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2556d3a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Fix capturing consts in modules 

    This might be a reason why regular `let` might be problematic in
modules. In the case of `const`, we can grab the value directly from
the parsed results, but with `let`, we might need to evaluate the
module.
    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    888c2c9 View commit details
    Browse the repository at this point in the history

  2. Allow importing constants using overlay use

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f92c00b View commit details
    Browse the repository at this point in the history

  3. Remove debug prints

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    628c865 View commit details
    Browse the repository at this point in the history

  4. Add a separate method for fetching constants

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    73d21fa View commit details
    Browse the repository at this point in the history

  5. Add tests

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    2d87b8f View commit details
    Browse the repository at this point in the history

  6. Fix nested list imports

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    62883b6 View commit details
    Browse the repository at this point in the history

  7. Add const test for overlay use

    @kubouch
    kubouch committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a1ce1b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Disable constants for overlay use for now

    @kubouch
    kubouch committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    db7d162 View commit details
    Browse the repository at this point in the history