Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "let config" warning #10068

Merged
merged 2 commits into from Aug 20, 2023
Merged

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Aug 20, 2023

Description

If you have a config variable defined at some point after reading config files, Nushell would print

warning: use `$env.config = ...` instead of `let config = ...`

I think it's long enough since we've used $env.config that we can remove this. Furthermore, it should be printed during let parsing because you can end up with a config constant after importing a config module (that was my case). The warning thus can be misleading.

User-Facing Changes

Tests + Formatting

After Submitting

Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@sholderbach sholderbach merged commit 66023f6 into nushell:main Aug 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants