Move pipeline code from cli to classified #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds modules for internal, external, and dynamic commands, as well as the pipeline functionality. These are exported as their old names from the classified module so as to keep its "interface" the same.
|
|
thegedge
commented
Nov 25, 2019
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps this should be a concern of cli.rs?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to do?
Refactor pipeline code, with the eventual goal of unifying the interface for
runbetween commands and pipelines.What have you done in this PR?
Two commits.
The first breaks up
classified.rsinto smaller submodules, to make it easier to isolate what's needed for each. Not technically necessary, but I've found it really helps me grok what's happening, and creates stronger boundaries around things (e.g.,LineCodecis only needed for external commands).The second moves most of the pipeline-y code out of
cli.rsintoclassified/pipeline.rs.ClassifiedPipelinehas now been given arunmethod, so it looks a lot like regular classified commands. I've also simplified the match cases for the pipeline.