Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
$nu
a parse-time constant. The benefits are two-fold:$nu
is now usable in more situations. For example, reloading the config file is now more convenient than ever:$nu
is now approximately 15x faster:The only remaining question is where to move the
eval_nu_variable()
since it is now not a part of the engine. I'm leaning towardsnu-protocol
which would move thesysinfo
dependency fromnu-engine
tonu-protocol
, alongside to introducingnu-path
dependency.User-Facing Changes
Enhances
$nu
usability, but everything should work exactly as before.Tests + Formatting
After Submitting