Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default env file to use $nu.home_path to find home #10192

Merged
merged 1 commit into from Sep 2, 2023

Conversation

mastermach50
Copy link
Contributor

@mastermach50 mastermach50 commented Sep 2, 2023

Description

Changed the default env file so that home is found using $nu.home-path instead to using an if-else statement to find the os then find the specific environment variable

@fdncred
Copy link
Collaborator

fdncred commented Sep 2, 2023

Thanks. Seems simpler that way. I'd probably also replace this part. I'm not sure exactly why it's so convoluted.

    let dir = ([
        ($env.PWD | str substring 0..($home | str length) | str replace $home "~"),
        ($env.PWD | str substring ($home | str length)..)
    ] | str join)

Seems like it could just be

let dir = $env.PWD | str replace $home ~

@mastermach50
Copy link
Contributor Author

mastermach50 commented Sep 2, 2023

@fdncred

that part is important
for edge cases like home path being /home/me and the PWD being /usr/bin/home/me

@fdncred
Copy link
Collaborator

fdncred commented Sep 2, 2023

ah, that makes sense.

@fdncred fdncred merged commit 844f541 into nushell:main Sep 2, 2023
19 checks passed
@amtoine
Copy link
Member

amtoine commented Sep 2, 2023

@mastermach50
i think using something like

$env.PWD | str replace --regex $'^($nu.home-path)' '~'

would do the same and still be easier to understand than

[
    ($env.PWD | str substring 0..($home | str length) | str replace $home "~"),
    ($env.PWD | str substring ($home | str length)..)
] | str join

amtoine added a commit to nushell/nushell.github.io that referenced this pull request Sep 17, 2023
this commit removes
| author        | description                                                | url                                                     |
| ------------- | ---------------------------------------------------------- | ------------------------------------------------------- |
| @kubouch      | Add NU_VERSION environment variable on startup             | [#10177](nushell/nushell#10177) |
| @mastermach50 | changed default env file to use $nu.home_path to find home | [#10192](nushell/nushell#10192) |
| @amtoine      | support tab completion cycling                             | [#10199](nushell/nushell#10199) |

because i'm not sure they are as interesting as the conditional sourcing
and the accessibility with screen reader friendly errors.
sholderbach added a commit to nushell/nushell.github.io that referenced this pull request Sep 19, 2023
* Create 2023-09-19-nushell_0_85_0.md

* add blurb about uutils/coreutils integration

* add the full template for the release notes

this commit also breaks the paragraph about uutils into multiple lines.

* add the raw table of contributions

* remove the bump / dependabot commits

* isolate the fixes

* more updates

* put all the PRs in proto sections

* move uutils PR to the correct section

* add TODOs and start completing some sections

* add the raw list of breaking changes

* add the full changelog

* write the "bug fixes" section

* fix a section title

* write the "documentation" section

* write the "making nushell better" section

this commit removes
| author        | description                                                | url                                                     |
| ------------- | ---------------------------------------------------------- | ------------------------------------------------------- |
| @kubouch      | Add NU_VERSION environment variable on startup             | [#10177](nushell/nushell#10177) |
| @mastermach50 | changed default env file to use $nu.home_path to find home | [#10192](nushell/nushell#10192) |
| @amtoine      | support tab completion cycling                             | [#10199](nushell/nushell#10199) |

because i'm not sure they are as interesting as the conditional sourcing
and the accessibility with screen reader friendly errors.

* write the "help with tests" section

* write the "changes to commands" section

* format and compact tables in the source

* write the "table themes" section

* write the `echo` section

* write the "python operators removal" section

* update the full changelog

* add proper uutils blog link

* Adds a note about mimalloc being default now (#1063)

* notes about history isolation changes

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

* type-o in sourcing and using

* `float` instead of `decimal` (#1064)

* `float` instead of `decimal`

* fix oopsie

* Breaking change markers

* Has nothing to do with pure documentation

* Add new commands section

* Deprecation section/ link new commands

* Fix `from` commands in the STD

* Fix subcommand std imports

* Mention removal of deprecated `--string`

* Refactor const section (#1068)

* Update 2023-09-19-nushell_0_85_0.md

Move code to code block

* add link to uutils blog post

* Small formulation tweaks to breaking changes

* cleanup dmatos part

* change link to our blogpost

* Add excerpt

* Excerpt in metadata

* Fix emphasis

---------

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Co-authored-by: amtoine <stevan.antoine@gmail.com>
Co-authored-by: Filip Andersson <17986183+FilipAndersson245@users.noreply.github.com>
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants