Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

change LOG_FORMAT to NU_LOG_FORMAT in nu-std library #10254

Merged
merged 1 commit into from Sep 6, 2023

Conversation

stormasm
Copy link
Contributor

@stormasm stormasm commented Sep 6, 2023

this closes #10248

@fdncred pointed out the problem and he was correct 馃槃

I went ahead and made the simple change and the
https://github.com/influxdata/influxdb_iox binary
works like a charm...

@amtoine hopefully there are no issues with this change

I believe its a good one as other rust binaries might take advantage of this common
environment variable as well...

@fdncred
Copy link
Collaborator

fdncred commented Sep 6, 2023

There was discussion a month back or so about using a consistent log format across nushell and std-lib. I wonder if that is why this was originally named LOG_FORMAT. Anyone remember?

@amtoine
Copy link
Member

amtoine commented Sep 6, 2023

There was discussion a month back or so about using a consistent log format across nushell and std-lib. I wonder if that is why this was originally named LOG_FORMAT. Anyone remember?

i think i remember this but as i cannot remember what was said and as we did not go further with that idea, i think we should make the change in the problematic part of Nushell, i.e. the LOG_FORMAT from std and see later to integrate with main Nushell if we want 馃構

@amtoine amtoine added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label Sep 6, 2023
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see three LOG_FORMATs on main, this PR changes 3 of them, i think this is just perfect 馃憤

thanks @stormasm 馃檹

@stormasm stormasm merged commit 6a37418 into nushell:main Sep 6, 2023
19 checks passed
@stormasm stormasm deleted the nustd-logfmt branch September 6, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the binary influxdb_iox crashes inside nushell when the nu-std lib is included
3 participants