Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slices directly instead of &Vec #10328

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Use slices directly instead of &Vec #10328

merged 4 commits into from
Sep 12, 2023

Commits on Sep 11, 2023

  1. Use slices directly instead of &Vec 

    Simplifies the signature, makes it more flexible.
Detected a few unnecessary allocations in the process.
    @sholderbach
    sholderbach committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6ce8775 View commit details
    Browse the repository at this point in the history

  2. Use &[u8] for overlay name references 

    As `slice::contains()` does not use the `Borrow` trait trick to make
the item type flexible like `HashMap::contains()`, use of equivalent
manual implementation (should not be specialized)
    @sholderbach
    sholderbach committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    20668d2 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary allocation in uniq-by

    @sholderbach
    sholderbach committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d789716 View commit details
    Browse the repository at this point in the history

  4. Two remaining &Vec

    @sholderbach
    sholderbach committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    dbd67fd View commit details
    Browse the repository at this point in the history