Improve assertions in src/tests.rs
#10449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention the expected substring in: - `fn run_test_contains()` - `fn test_ide_contains()` - `fn fail_test()`
amtoine
approved these changes
Sep 21, 2023
Move it out of the immediate panic message and below rest of the output. This is easier to identify.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description Mention the expected substring in: - `fn run_test_contains()` - `fn test_ide_contains()` - `fn fail_test()` # Developer-Facing Changes You can read the test failure to figure out what is going on, don't necessarily have to look up the test New look of failure ``` failures: ---- tests::test_math::broken_math stdout ---- stdout: stderr: Error: nu::parser::incomplete_math_expression × Incomplete math expression. ╭─[/tmp/.tmpz0V8nC:1:1] 1 │ 3 + · ┬ · ╰── incomplete math expression ╰──── Expected error to contain: Incomplete universe thread 'tests::test_math::broken_math' panicked at 'assertion failed: !stderr.is_empty() && stderr.contains(expected)', src/tests.rs:181:5 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mention the expected substring in:
fn run_test_contains()fn test_ide_contains()fn fail_test()Developer-Facing Changes
You can read the test failure to figure out what is going on, don't necessarily have to look up the test
New look of failure
Tests + Formatting
This is an assetion used in several tests in the workspace root