nu-explore: Try to fix a truncation issue in expand view #10580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, this fixes the problem but creates another problem. This fix removes all the colors. |
|
To bisect things can you recheckout the |
|
I checked it out and re-compiled with the main branches cargo.lock file and the non-coloring issue still exists. |
|
Latest commit fixes the coloring issues. Thanks! |
|
Thanks! |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
I haven't tested cause can't reproduce, but the issue very likely was related to a emojies. (I mean I probably could but ....) Could you try it @fdncred? fix nushell#10560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested cause can't reproduce, but the issue very likely was related to a emojies. (I mean I probably could but ....)
Could you try it @fdncred?
fix #10560