Let run_in_login_mode succeed even with broken local config
#10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
Oct 6, 2023
I wondered why this test failed for me. Turns out my config file is not compatible with current main, but the error message was useless. I've added `--no-config-file`.
Hofer-Julian
force-pushed
the
simplify_login_test
branch
from
f929c5c
to
07dce53
Compare
|
@sholderbach I've had another look, and I am less confident now that checking the status code will do it. |
|
@Hofer-Julian @sholderbach |
Yes, it solves the issue and IMO ready to land |
sholderbach
approved these changes
Oct 10, 2023
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
…l#10622) I wondered why this test failed for me. Turns out my config file is not compatible with current main, but the error message was useless. I've added `--no-config-file`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered why this test failed for me.
Turns out my config file is not compatible with current main, but the error message was useless. I've added
--no-config-fileand improved the surrounding tests a bit while I was at it.