Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong parsing of signatures in predecl scan #10637

Merged
merged 1 commit into from Oct 7, 2023

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Oct 7, 2023

Description

Fixes #10605

Seems like when we introduced input/output types, we didn't update signature parsing in the predecl scan. I'm surprised it hasn't caused any issues until recently.

User-Facing Changes

Fixed a bug

Tests + Formatting

After Submitting

@kubouch kubouch merged commit 67b5e1b into nushell:main Oct 7, 2023
19 checks passed
@kubouch kubouch deleted the fix-def-predecl branch October 7, 2023 13:42
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong signature parsing in predecl scan
1 participant