Revert "Bump regex from 1.9.6 to 1.10.2" #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74d3f3c.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
Reverts nushell#10812 This goes back to a version of `regex` and its dependencies that is shared with a lot of our other dependencies. Before this we did not duplicate big dependencies of `regex` that affect binary size and compile time. As there is no known bug or security problem we suffer from, we can wait on receiving the performance improvements to `regex` with the rest of our `regex` dependents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10812
This goes back to a version of
regexand its dependencies that is shared with a lot of our other dependencies. Before this we did not duplicate big dependencies ofregexthat affect binary size and compile time.As there is no known bug or security problem we suffer from, we can wait on receiving the performance improvements to
regexwith the rest of ourregexdependents.