Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pattern matching null literals #10829

Merged
merged 1 commit into from Oct 24, 2023
Merged

Support pattern matching null literals #10829

merged 1 commit into from Oct 24, 2023

Conversation

hudclark
Copy link
Contributor

Description

Support pattern matching against the null literal. Fixes #10799

Before

> match null { null => "success", _ => "failure" }
failure

After

> match null { null => "success", _ => "failure" }
success

User-Facing Changes

Users can pattern match against a null literal.

fdncred
fdncred approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

WindSoilder
WindSoilder approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@WindSoilder WindSoilder merged commit 78b4472 into nushell:main Oct 24, 2023
19 checks passed
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
@hudclark @hardfau1t
Support pattern matching null literals (nushell#10829)
26dd8a8 
# Description
Support pattern matching against the `null` literal.  Fixes nushell#10799 

### Before
```nushell
> match null { null => "success", _ => "failure" }
failure
```

### After
```nushell
> match null { null => "success", _ => "failure" }
success
```

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
Users can pattern match against a `null` literal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdncred fdncred fdncred approved these changes

@WindSoilder WindSoilder WindSoilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't match a null (but can using the deprecated $nothing)
3 participants
@hudclark @fdncred @WindSoilder