remove --not from glob
#10839
Merged
remove --not from glob
#10839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
added
pr:breaking-change
sholderbach
added
removal-after-deprecation
12 tasks
melMass
added a commit
to amtoine/nu-git-manager
that referenced
this pull request
Nov 17, 2023
related to - nushell/nushell#10827 - nushell/nushell#10839 ## description `glob --not` has been deprecated in nushell/nushell#10827 and will be removed in nushell/nushell#10839 before 0.88.0 in favor of `glob --exclude`. this PR performs the change in `nu-git-manager`. Co-authored-by: Mel Massadian <melmassadian@gmail.com>
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10827 > **Important** > wait for between 0.87 and 0.88 to land this # Description after deprecation comes removal... this PR removes `glob --not` in favor of `glob --exclude`. # User-Facing Changes `glob --not` will stop working. # Tests + Formatting # After Submitting i didn't find any use of `glob --not` in the `nu_scripts` so no update required there 馃憤
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10827 > **Important** > wait for between 0.87 and 0.88 to land this # Description after deprecation comes removal... this PR removes `glob --not` in favor of `glob --exclude`. # User-Facing Changes `glob --not` will stop working. # Tests + Formatting # After Submitting i didn't find any use of `glob --not` in the `nu_scripts` so no update required there 馃憤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to
glob --notin favor ofglob --exclude聽#10827Description
after deprecation comes removal... this PR removes
glob --notin favor ofglob --exclude.User-Facing Changes
glob --notwill stop working.Tests + Formatting
After Submitting
i didn't find any use of
glob --notin thenu_scriptsso no update required there 馃憤