remove def-env and export def-env
#10999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the files with
```nushell
ls **/*.rs | find --regex def_env | each { rm --verbose $in.name }`
```
- run `:g/DefEnv/d` in `crates/nu-cmd-lang/src/default_context.rs`
- run `:g/def_env/d` in `crates/nu-cmd-lang/src/core_commands/mod.rs`
amtoine
added
wait-until-after-nushell-release
pr:breaking-change
amtoine
force-pushed
the
remove-def-env
branch
from
5060475
to
1fcbeb7
Compare
sholderbach
added
removal-after-deprecation
12 tasks
|
Hi @amtoine , would you please fix the conflicts? I believe it's conflict with |
this should solve the merge conflict from nushell#10999
|
yup, should be better now @WindSoilder 馃槈 |
|
I'm sorry that I didn't review it yesterday, it seems that we still have comflicts...Can you please resolve it again? |
this should solve the merge conflict in nushell#10999.
|
no worries @WindSoilder, should be good to go again 馃槈 |
WindSoilder
approved these changes
Nov 19, 2023
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10715 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 馃構 this PR removes `def-env` and `export def-env` in favor of `def --env` # User-Facing Changes `def-env` and `export def-env` will not be found anymore. # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10715 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 馃構 this PR removes `def-env` and `export def-env` in favor of `def --env` # User-Facing Changes `def-env` and `export def-env` will not be found anymore. # Tests + Formatting # After Submitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to
def-envandexport def-env聽#10715Description
it's time for removal again 馃構
this PR removes
def-envandexport def-envin favor ofdef --envUser-Facing Changes
def-envandexport def-envwill not be found anymore.Tests + Formatting
After Submitting