Fix tests for cargo.exe check command #11022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaetschwartz |
|
On my local windows machine, when I run |
|
Good solution! Thanks. |
gaetschwartz
added a commit
to gaetschwartz/nushell
that referenced
this pull request
Nov 11, 2023
This pull request fixes the tests for the `cargo.exe check` command. The tests were failing due `cargo check -h` sometimes reporting `cargo.exe` as the binary and thus not containing `cargo check` in the output. The fix involves using the `Command` module from the `std::process` library to run the command and comparing its output to the expected output. No changes were made to the codebase itself.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
This pull request fixes the tests for the `cargo.exe check` command. The tests were failing due `cargo check -h` sometimes reporting `cargo.exe` as the binary and thus not containing `cargo check` in the output. The fix involves using the `Command` module from the `std::process` library to run the command and comparing its output to the expected output. No changes were made to the codebase itself.
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
This pull request fixes the tests for the `cargo.exe check` command. The tests were failing due `cargo check -h` sometimes reporting `cargo.exe` as the binary and thus not containing `cargo check` in the output. The fix involves using the `Command` module from the `std::process` library to run the command and comparing its output to the expected output. No changes were made to the codebase itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the tests for the
cargo.exe checkcommand. The tests were failing duecargo check -hsometimes reportingcargo.exeas the binary and thus not containingcargo checkin the output.The fix involves using the
Commandmodule from thestd::processlibrary to run the command and comparing its output to the expected output. No changes were made to the codebase itself.