Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (http) get HTTP_PROXY from $env #11026

Merged
merged 2 commits into from Nov 11, 2023
Merged

Fix (http) get HTTP_PROXY from $env #11026

merged 2 commits into from Nov 11, 2023

Conversation

FMotalleb
Copy link
Contributor

@FMotalleb FMotalleb commented Nov 11, 2023 •
edited

Description

This PR closes this issue

User-Facing Changes

Setting the environment variable HTTP_PROXY using $env.HTTP_PROXY will work.

Before

~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
IR # (direct)

After

~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
DE # (with proxy)

@kubouch
Copy link
Contributor

kubouch commented Nov 11, 2023

This fix seems correct. We don't use std::env in Nushell at all, so anything that relies on it will be broken.

@FMotalleb FMotalleb changed the title Fix get HTTP_PROXY from $env Fix (http) get HTTP_PROXY from $env Nov 11, 2023
fdncred
fdncred approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@fdncred fdncred merged commit 415b127 into nushell:main Nov 11, 2023
19 checks passed
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
@FMotalleb @hardfau1t
Fix (http) get HTTP_PROXY from $env (nushell#11026)
e8be092 
# Description

This PR closes this
[issue](nushell#11025)

# User-Facing Changes

Setting the environment variable HTTP_PROXY using $env.HTTP_PROXY will
work.

# Before

```bash
~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
IR # (direct)
```

# After

```bash
~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
DE # (with proxy)
```
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
@FMotalleb @dmatos2012
Fix (http) get HTTP_PROXY from $env (nushell#11026)
e9b10ba 
# Description

This PR closes this
[issue](nushell#11025)

# User-Facing Changes

Setting the environment variable HTTP_PROXY using $env.HTTP_PROXY will
work.

# Before

```bash
~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
IR # (direct)
```

# After

```bash
~> $env.HTTP_PROXY = http://127.0.0.1:7890 | http get https://lumtest.com/myip.json | get country
DE # (with proxy)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdncred fdncred fdncred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FMotalleb @kubouch @fdncred