Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to clearer reedline keyboard enhancement API #11045

Merged
merged 2 commits into from
Nov 14, 2023

Commits on Nov 13, 2023

  1. Move to clearer reedline keyboard enhancement API

    Go from the ill-defined `enable/disable` pairs to `.use_...` builders
    This alleviates unclear properties when the underlying enhancements are
    enabled. Now they are enabed when entering `Reedline::read_line` and
    disabled when exiting that.
    
    Furthermore allow setting `$env.config.use_kitty_protocol` to have an
    effect when toggling during runtime. Previously it was only enabled when
    receiving a value from `config.nu`. I kept the warning code there to not
    pollute the log. We could move it into the REPL-loop if desired
    
    Not sure if we should actively block the enabling of `bracketed_paste`
    on Windows. Need to test what happens if it just doesn't do anything we
    could remove the `cfg!` switch. At least for WSL2 Windows Terminal
    already supports bracketed paste. `target_os = windows` is a bad
    predictor for `conhost.exe`.
    
    Depends on nushell/reedline#659
    (pointing to personal fork)
    
    Closes nushell#10982
    Supersedes nushell#10998
    sholderbach committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    45cdcaa View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Point to main

    sholderbach committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5d0df0d View commit details
    Browse the repository at this point in the history