Wait for process instead of polling its status. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a huge performance boost for pipelines that end in an external command. Rough testing shows an improvement from roughly 400ms to 30ms when `cat`-ing a large file.
|
|
bobhy
pushed a commit
to bobhy/nushell
that referenced
this pull request
Oct 22, 2023
one might start in the middle of the section the variable scores is defined above the example might not result the expected results, hence ensuring assignment is done before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a huge performance boost for pipelines that end in an external command. Rough testing shows an improvement from roughly 400ms to 30ms when
cat-ing a large file (see #1056 (comment) for related profiling scenarios).