Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ShellError::AliasNotFound to named fields #11118

Merged
merged 1 commit into from Nov 21, 2023

Conversation

drbrain
Copy link
Contributor

@drbrain drbrain commented Nov 21, 2023

Description

Part of #10700

User-Facing Changes

None

Tests + Formatting

  • 馃煝 toolkit fmt
  • 馃煝 toolkit clippy
  • 馃煝 toolkit test
  • 馃煝 toolkit test stdlib

After Submitting

N/A

Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's really good to see we make some progress on #10700

@WindSoilder WindSoilder merged commit 0578cf8 into nushell:main Nov 21, 2023
19 checks passed
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
# Description

Part of nushell#10700

# User-Facing Changes

None

# Tests + Formatting

- 馃煝 `toolkit fmt`
- 馃煝 `toolkit clippy`
- 馃煝 `toolkit test`
- 馃煝 `toolkit test stdlib`

# After Submitting

N/A
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
# Description

Part of nushell#10700

# User-Facing Changes

None

# Tests + Formatting

- 馃煝 `toolkit fmt`
- 馃煝 `toolkit clippy`
- 馃煝 `toolkit test`
- 馃煝 `toolkit test stdlib`

# After Submitting

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants