Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get -i ignoring errors for only the first cellpath #11213

Merged
merged 1 commit into from Dec 2, 2023

Conversation

IanManske
Copy link
Member

Description

Fixes issue #11212 where only the first cellpath supplied to get -i is treated as optional, and the rest of the cell paths are treated as non-optional.

Tests

Added one test.

@fdncred
Copy link
Collaborator

fdncred commented Dec 2, 2023

Nice work! Do you think the same thing needs to be done for select -i?

@IanManske
Copy link
Member Author

Just tested select -i, looks like it currently works fine.

@fdncred
Copy link
Collaborator

fdncred commented Dec 2, 2023

Thanks for checking select and making this fix! We appreciate you @IanManske!!

@fdncred fdncred merged commit 35e8db1 into nushell:main Dec 2, 2023
19 checks passed
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
# Description
Fixes issue nushell#11212 where only the first cellpath supplied to `get -i` is
treated as optional, and the rest of the cell paths are treated as
non-optional.

# Tests
Added one test.
@IanManske IanManske deleted the get-ignore-fix branch December 17, 2023 16:34
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
# Description
Fixes issue nushell#11212 where only the first cellpath supplied to `get -i` is
treated as optional, and the rest of the cell paths are treated as
non-optional.

# Tests
Added one test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants