New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce required, optional, and rest positional arguments start with an uppercase and end with a period. #11285
Conversation
wow, that's a lot of changes. thanks for all the hard work. i'm especially glad to enforce consistency with tests. i'm a little bit nervous on landing this one before our release tomorrow since it's so big. |
I'm in no rush to merge |
Hi @drbrain 👋, where does one find the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I really love these two added tests: arguments_start_uppercase, arguments_end_period
@drbrain I'm wondering if all parameters are checked for uppercase and period. I just landed a PR that passed the test but didn't have a period in the switches. https://github.com/nushell/nushell/pull/11324/files#diff-61e5ce298fd8925da5182d9bddcf1d27568c5a74ece04c9f9b8a699688ec5bbcR481-R484 |
This change seems to have a few problems, and does not match with what was agreed in #5066:
However, this PR enforces the opposite, and now parameters are inconsistent with flags, even though they're both arguments (in the argv sense). Also, now the For example, in
Instead of the cleaner and more consistent:
|
…an uppercase and end with a period. (nushell#11285) # Description This updates all the positional arguments (except with `--features=dataframe` or `--features=extra`) to start with an uppercase letter and end with a period. Part of nushell#5066, specifically [this comment](/nushell/issues/5066#issuecomment-1421528910) Some arguments had example data removed from them because it also appears in the examples. There are other inconsistencies in positional arguments I noticed while making the tests pass which I will bring up in nushell#5066. # User-Facing Changes Positional arguments are now consistent # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Automatic documentation updates
Description
This updates all the positional arguments (except with
--features=dataframe
or--features=extra
) to start with an uppercase letter and end with a period.Part of #5066, specifically this comment
Some arguments had example data removed from them because it also appears in the examples.
There are other inconsistencies in positional arguments I noticed while making the tests pass which I will bring up in #5066.
User-Facing Changes
Positional arguments are now consistent
Tests + Formatting
toolkit fmt
toolkit clippy
toolkit test
toolkit test stdlib
After Submitting
Automatic documentation updates