Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve completions of use and overlay use #11330

Merged
merged 8 commits into from
Dec 19, 2023
Merged

improve completions of use and overlay use #11330

merged 8 commits into from
Dec 19, 2023

Commits on Dec 14, 2023

  1. use same completions for use and overlay use

    @amtoine
    amtoine committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    48f29b6 View commit details
    Browse the repository at this point in the history

  2. completes NU_LIB_DIRS with directory modules 

    this checks if `search dir + it + mod.nu` exists and adds that to the
completion items if so.
i renamed the outter `it` to `search_dir` to avoid it being shadowed by
the innermost one and avoid defining a binding with the same name.
    @amtoine
    amtoine committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    402acde View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. format the code

    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    eba2ec6 View commit details
    Browse the repository at this point in the history

  2. test overlay use as use and source-env

    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    74c29ed View commit details
    Browse the repository at this point in the history

  3. add a directory module to the completions 

    the CI should fail here.
    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8c00b0b View commit details
    Browse the repository at this point in the history

  4. fix the tests 

    the CI should go green again here.
    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    b425a8d View commit details
    Browse the repository at this point in the history

  5. fix the other tests

    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9a289d8 View commit details
    Browse the repository at this point in the history

  6. fix _dotnu_ test on Windows

    @amtoine
    amtoine committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7be15d0 View commit details
    Browse the repository at this point in the history