📝 Update str trim CLI help doc
#11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wat 😮 . I didn't expected the check to pass. I guess "this doesn't work on my machine but github says it is okay" is the new works in my machine lol This can be merged but, is anybody having the same problem? |
|
ok, thanks. |
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description Hi! I updated the samples of `str trim` because there were repeated and clarified the explanations # User-Facing Changes Yes! I send the details here:  (`old` is version `88.1` not the latest main) # Tests + Formatting ~~I ran `toolkit check pr` successfully~~ There was a tiny problem, a test I never touched now it's failing ```nu (^echo a | complete) == {stdout: "a\n", exit_code: 0} ``` should output `true` but outputs `false`, both in my running `nu` version and in my PR version This make the test `nu-command::main commands::complete::basic` fail located in `crates\nu-command\tests\commands\complete.rs` # After Submitting I'm not sure if I need to update nushell.github.io, some of the help is auto-generated, but maybe not all? I can file a PR if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! I updated the samples of
str trimbecause there were repeated and clarified the explanationsUser-Facing Changes
Yes! I send the details here:
(
oldis version88.1not the latest main)Tests + Formatting
I rantoolkit check prsuccessfullyThere was a tiny problem, a test I never touched now it's failing
should output
truebut outputsfalse, both in my runningnuversion and in my PR versionThis make the test
nu-command::main commands::complete::basicfaillocated in
crates\nu-command\tests\commands\complete.rsAfter Submitting
I'm not sure if I need to update nushell.github.io, some of the help is auto-generated, but maybe not all?
I can file a PR if needed