Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the feature gates for stor commands #11416

Merged
merged 1 commit into from Dec 24, 2023
Merged

Simplify the feature gates for stor commands #11416

merged 1 commit into from Dec 24, 2023

Conversation

sholderbach
Copy link
Member

All of them depend on feature sqlite so just conditionally use the
parent module.

@sholderbach
Simplify the feature gates for stor commands
10b788d 
All of them depend on feature `sqlite` so just conditionally `use` the
parent module.
@sholderbach sholderbach merged commit 543a255 into nushell:main Dec 24, 2023
19 checks passed
@sholderbach sholderbach deleted the simplify-stor-gates branch December 24, 2023 12:31
@fdncred
Copy link
Collaborator

fdncred commented Dec 24, 2023

thanks. i thought it was stupid to put #[cfg(feature = "sqlite")] on each line but could figure out how to do what this pr does. :-)

dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
@sholderbach @dmatos2012
Simplify the feature gates for stor commands (nushell#11416)
c9d2373 
All of them depend on feature `sqlite` so just conditionally `use` the
parent module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sholderbach @fdncred