Plugin explicit flags #11581
Merged
Plugin explicit flags #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
added
the
pr:breaking-change
|
I'm fixing that clippy ci error in another pr now. ugh, i hate breaking changes in plugins. it usually means every single plugin has to be recompiled. |
|
you'll need to rebase to integrate those changes |
NotLebedev
force-pushed
the
plugin-explicit-flags
branch
from
07fc0d4
to
b96ec96
Compare
Done |
|
Unfortunately, this change is probably necessary for consistency. Thanks @NotLebedev! |
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description nushell#11492 fixed flags for builtin commands but I missed that plugins don't use the same `has_flag` that builtins do. This PR addresses this. Unfortunately this means that return value of `has_flag` needs to change from `bool` to `Result<bool, ShellError>` to produce an error when explicit value is not a boolean (just like in case of `has_flag` for builtin commands. It is not possible to check this in `EvaluatedCall::try_from_call` because # User-Facing Changes Passing explicit values to flags of plugin commands (like `--flag=true` `--flag=false`) should work now. BREAKING: changed return value of `EvaluatedCall::has_flag` method from `bool` to `Result<bool, ShellError>` # Tests + Formatting Added tests and updated documentation and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#11492 fixed flags for builtin commands but I missed that plugins don't use the same
has_flagthat builtins do. This PR addresses this.Unfortunately this means that return value of
has_flagneeds to change frombooltoResult<bool, ShellError>to produce an error when explicit value is not a boolean (just like in case ofhas_flagfor builtin commands. It is not possible to check this inEvaluatedCall::try_from_callbecauseUser-Facing Changes
Passing explicit values to flags of plugin commands (like
--flag=true--flag=false) should work now.BREAKING: changed return value of
EvaluatedCall::has_flagmethod frombooltoResult<bool, ShellError>Tests + Formatting
Added tests and updated documentation and examples